You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2014/06/25 19:20:20 UTC

[GitHub] incubator-brooklyn pull request: Fix LocalhostExternalIpLoader.get...

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/20

    Fix LocalhostExternalIpLoader.getLocalhostIpWithin

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/incubator-brooklyn fix/external-ip-loader

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit f11cc4dbf5fac358d41a22d4e11abc423a0e99d4
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2014-06-25T17:20:02Z

    Fix LocalhostExternalIpLoader.getLocalhostIpWithin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix LocalhostExternalIpLoader.get...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix LocalhostExternalIpLoader.get...

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/20#issuecomment-47211159
  
    good needed fix, merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix LocalhostExternalIpLoader.get...

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/20#discussion_r14234124
  
    --- Diff: core/src/main/java/brooklyn/location/geo/LocalhostExternalIpLoader.java ---
    @@ -92,8 +92,10 @@ public static String getLocalhostIpWaiting() {
          */
         public static String getLocalhostIpWithin(Duration timeout) {
             String result = doLoad(timeout);
    -        if (result!=null) return null;
    --- End diff --
    
    oops.  who did this?  <sheepish look>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---