[GitHub] [pinot] walterddr commented on a diff in pull request #7358: [issue-7357] Add support for Avro logical types in realtime ingestion

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #7358:
URL: https://github.com/apache/pinot/pull/7358#discussion_r844135560


##########
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##########
@@ -31,22 +34,22 @@
 import org.apache.pinot.spi.data.readers.GenericRow;
 import org.apache.pinot.spi.data.readers.RecordExtractorConfig;
 
-
-/**
- * Extractor for Avro Records
- */
+/** Extractor for Avro Records */
 public class AvroRecordExtractor extends BaseRecordExtractor<GenericRecord> {
   private Set<String> _fields;
   private boolean _extractAll = false;
+  private boolean _applyLogicalTypes = false;

Review Comment:
   yes I think we can create a `AvroRecordExtractorConfig` and provide some defaults to this if necessary. see `CsvRecordExtractorConfig` as an example. i think it can be part of this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org