[GitHub] [kafka] cmccabe commented on a change in pull request #11606: MINOR: Add shutdown tests for KRaft

[GitBox <gi...@apache.org>]

cmccabe commented on a change in pull request #11606:
URL: https://github.com/apache/kafka/pull/11606#discussion_r781650275



##########
File path: core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala
##########
@@ -196,14 +199,16 @@ abstract class QuorumTestHarness extends Logging {
     }
   }
 
-  def createAndStartBroker(config: KafkaConfig,
-                           time: Time = Time.SYSTEM): KafkaBroker = {
-    implementation.createAndStartBroker(config,
-      time)
+  def createBroker(config: KafkaConfig,
+                   time: Time = Time.SYSTEM,
+                   startup: Boolean = true): KafkaBroker = {
+    implementation.createBroker(config, time, startup)
   }
 
   def shutdownZooKeeper(): Unit = asZk().shutdown()
 
+  def shutdownKRaftController(): Unit = asKRaft().shutdown()

Review comment:
       This function isn't named correctly. It will shut down more than just the controller. It also shuts down the RaftManager which is used by the brokers. If you are OK shutting down both things in your test, I'd suggest just calling `shutdown()` directly rather than creating an alias like this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org