You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/04 20:14:03 UTC

[GitHub] [spark] huaxingao opened a new pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

huaxingao opened a new pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121
 
 
   
   
   ### What changes were proposed in this pull request?
   Document join in SQL Reference.
   
   ### Why are the changes needed?
   To make SQL Reference complete.
   
   
   ### Does this PR introduce any user-facing change?
   Yes
   <img width="1050" alt="Screen Shot 2020-04-04 at 12 53 41 PM" src="https://user-images.githubusercontent.com/13592258/78460413-9a49cb00-7675-11ea-917b-2018728b0d25.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 12 54 06 PM" src="https://user-images.githubusercontent.com/13592258/78460414-9ae26180-7675-11ea-847a-b3b979d6a8dd.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 12 58 01 PM" src="https://user-images.githubusercontent.com/13592258/78460416-9d44bb80-7675-11ea-9e4e-4d3c31e813bf.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 12 58 15 PM" src="https://user-images.githubusercontent.com/13592258/78460418-a0d84280-7675-11ea-82b8-4ff6386dac00.png">
   
   <img width="1051" alt="Screen Shot 2020-04-04 at 12 59 16 PM" src="https://user-images.githubusercontent.com/13592258/78460421-a33a9c80-7675-11ea-849f-345b6c3c9594.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 12 59 27 PM" src="https://user-images.githubusercontent.com/13592258/78460422-a59cf680-7675-11ea-9637-072c019c994c.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 00 49 PM" src="https://user-images.githubusercontent.com/13592258/78460423-a897e700-7675-11ea-9f52-304154a5dd76.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 01 05 PM" src="https://user-images.githubusercontent.com/13592258/78460425-aafa4100-7675-11ea-8495-990162464aee.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 01 33 PM" src="https://user-images.githubusercontent.com/13592258/78460427-ad5c9b00-7675-11ea-9920-6edf430ca249.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 01 48 PM" src="https://user-images.githubusercontent.com/13592258/78460432-b0578b80-7675-11ea-8137-e53118e618ab.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 02 14 PM" src="https://user-images.githubusercontent.com/13592258/78460434-b2214f00-7675-11ea-93a1-8700c30b20c1.png">
   
   <img width="1051" alt="Screen Shot 2020-04-04 at 1 02 48 PM" src="https://user-images.githubusercontent.com/13592258/78460435-b3eb1280-7675-11ea-9b23-4f5dd202f98d.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 02 57 PM" src="https://user-images.githubusercontent.com/13592258/78460437-b64d6c80-7675-11ea-8988-2e4992c3cfce.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 04 27 PM" src="https://user-images.githubusercontent.com/13592258/78460439-b8afc680-7675-11ea-9f60-dcc52c1c9f7c.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 04 38 PM" src="https://user-images.githubusercontent.com/13592258/78460444-bc434d80-7675-11ea-9e7e-603deac0ae73.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 05 09 PM" src="https://user-images.githubusercontent.com/13592258/78460446-be0d1100-7675-11ea-82e3-ea2196a36278.png">
   
   <img width="1050" alt="Screen Shot 2020-04-04 at 1 05 18 PM" src="https://user-images.githubusercontent.com/13592258/78460447-c1080180-7675-11ea-8def-24ff2acc72f7.png">
   
   
   
   
   ### How was this patch tested?
   Manually build and check.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r405177521
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,236 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
 
 Review comment:
   I am OK either way. 
   @maropu WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609951800
 
 
   **[Test build #120883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120883/testReport)** for PR 28121 at commit [`1318624`](https://github.com/apache/spark/commit/1318624e06edbad233d2818c2acc325ad4e4e096).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609918963
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120880/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194822
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25594/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944735
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25575/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610645325
 
 
   **[Test build #120938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120938/testReport)** for PR 28121 at commit [`211f2f9`](https://github.com/apache/spark/commit/211f2f929422f1180f52e346760146f957302e25).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609553781
 
 
   **[Test build #120855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120855/testReport)** for PR 28121 at commit [`4dbf2f4`](https://github.com/apache/spark/commit/4dbf2f4bca52d1effa22b1d979083589cd6f2bc0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404236741
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ INNER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Left Join </b><br>
+A left join returns all values from the left relation and the matched values from the right relation, or appends NULL if there is no match. It is also referred to as a left outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation LEFT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Right Join </b><br>
+A right join returns all values from the right relation and the matched values from the left relation, or appends NULL if there is no match. It is also referred to as a right outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation RIGHT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Full Join </b><br>
+A full join returns all values from both relations, appending NULL values on the side that does not have a match. It is also referred to as a full outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation FULL [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Cross Join </b><br>
+A cross join returns the Cartesian product of two relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation CROSS JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Semi Join </b><br>
+A semi join returns values from the left side of the relation that has a match with the right. It is also referred to as a left semi join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] SEMI JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Anti Join </b><br>
+An anti join returns values from the left relation that has no match with the right. It is also referred to as a left anti join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] ANTI JOIN relation [ join_criteria ]
+    </code>
+
+### Examples
+{% highlight sql %}
+-- Use employee and department tables to demonstrate different type of joins.
+SELECT * FROM employee;
+
+  +---+-----+-------+
+  |id |name |deptno |
+  +---+-----+-------+
+  |105|Chloe|5      |
+  |103|Paul |3      |
+  |101|John |1      |
+  |102|Lisa |2      |
+  |104|Evan |4      |
+  |106|Amy  |6      |
+  +---+-----+-------+
+
+SELECT * FROM department;
+  +-------+-----------+
+  |deptno |deptname   |
+  +-------+-----------+
+  |3      |Engineering|
+  |2      |Sales      |
+  |1      |Marketing  |
+  +-------+-----------+
+
+-- Use employee and department tables to demonstrate inner join.
+SELECT id, name, employee.deptno, deptname
+  FROM employee INNER JOIN department ON employee.deptno = department.deptno;
 
 Review comment:
   I prefer either 2 or 4 spaces. 
   I checked a few SQL Reference:
   DB2, Snowflake 2 spaces
   SQL Server, PostgreSQL 4 spaces
   Oracle 3 spaces
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610177064
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083872
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610198535
 
 
   **[Test build #120902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120902/testReport)** for PR 28121 at commit [`65d82e0`](https://github.com/apache/spark/commit/65d82e05bfee39119bf0b7c551cd1f55dbea7116).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403882998
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
 
 Review comment:
   nit: need some indents

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341505
 
 
   **[Test build #121003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121003/testReport)** for PR 28121 at commit [`ffe4e09`](https://github.com/apache/spark/commit/ffe4e0995fd249e2fc6a0334007da002c8fcf278).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341885
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25695/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639844
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341885
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25695/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194822
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25594/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r405191761
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,236 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
 
 Review comment:
   Yea, better to document `NATURAL JOIN`, too, as the Pg doc does so: https://www.postgresql.org/docs/current/sql-select.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609552010
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25549/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194438
 
 
   **[Test build #120902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120902/testReport)** for PR 28121 at commit [`65d82e0`](https://github.com/apache/spark/commit/65d82e05bfee39119bf0b7c551cd1f55dbea7116).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611825206
 
 
   **[Test build #121048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121048/testReport)** for PR 28121 at commit [`5ae2bf7`](https://github.com/apache/spark/commit/5ae2bf7bd453bed1529d41ab39ffca3e02705de6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944720
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174263
 
 
   **[Test build #120896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120896/testReport)** for PR 28121 at commit [`8be6c4a`](https://github.com/apache/spark/commit/8be6c4a12ffb783d938d91b69d6ddd1c191af75d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404544033
 
 

 ##########
 File path: docs/_data/menu-sql.yaml
 ##########
 @@ -154,7 +154,9 @@
                   url: sql-ref-syntax-qry-select-distribute-by.html
                 - text: LIMIT Clause 
                   url: sql-ref-syntax-qry-select-limit.html
-                - text: Join Hints
+                - text: JOIN
+                  url: sql-ref-syntax-qry-select-join.html
+                - text: JOIN HINTS
 
 Review comment:
   Why we need to upper case of hints? We don't really have `HINTS` in query. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611825271
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121048/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609085017
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083875
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25512/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822993
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174696
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403784250
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON booleanExpression | USING ( column_name [ , column_name ... ] )
 
 Review comment:
   `booleanExpression` -> `boolean_expression`? Also, we need the corresponding explanation about `boolean_expression` here, too? https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-qry-select.md#L42

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609555952
 
 
   **[Test build #120856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120856/testReport)** for PR 28121 at commit [`84bc563`](https://github.com/apache/spark/commit/84bc5632fd3c08188f2c2b0d6758ff129ee955a2).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610177064
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609911753
 
 
   **[Test build #120880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120880/testReport)** for PR 28121 at commit [`a2a8528`](https://github.com/apache/spark/commit/a2a8528217d615d743ea69ebfb4ce911da3815b6).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609918953
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639309
 
 
   **[Test build #120938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120938/testReport)** for PR 28121 at commit [`211f2f9`](https://github.com/apache/spark/commit/211f2f929422f1180f52e346760146f957302e25).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403880062
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
 
 Review comment:
   nit: `Spark` -> `Spark  SQL`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609556284
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25550/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609912414
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611345589
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-612688243
 
 
   Thanks, all!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944130
 
 
   **[Test build #120883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120883/testReport)** for PR 28121 at commit [`1318624`](https://github.com/apache/spark/commit/1318624e06edbad233d2818c2acc325ad4e4e096).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822995
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25739/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944735
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25575/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174696
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083875
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25512/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609952068
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120883/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609556278
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609558529
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609912426
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25572/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610177594
 
 
   cc: @srowen @viirya 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403787456
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON booleanExpression | USING ( column_name [ , column_name ... ] )
+      </code>
+  </dd>
+</dl>
+
+### Join Types
+- [INNER JOIN](sql-ref-syntax-qry-select-join-inner.html)
+- [LEFT JOIN](sql-ref-syntax-qry-select-join-left.html)
+- [RIGHT JOIN](sql-ref-syntax-qry-select-join-right.html)
+- [FULL JOIN](sql-ref-syntax-qry-select-join-full.html)
+- [CROSS JOIN](sql-ref-syntax-qry-select-join-cross.html)
+- [SEMI JOIN](sql-ref-syntax-qry-select-join-semi.html)
+- [ANTI JOIN](sql-ref-syntax-qry-select-join-anti.html)
 
 Review comment:
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403786206
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON booleanExpression | USING ( column_name [ , column_name ... ] )
+      </code>
+  </dd>
+</dl>
+
+### Join Types
+- [INNER JOIN](sql-ref-syntax-qry-select-join-inner.html)
+- [LEFT JOIN](sql-ref-syntax-qry-select-join-left.html)
+- [RIGHT JOIN](sql-ref-syntax-qry-select-join-right.html)
+- [FULL JOIN](sql-ref-syntax-qry-select-join-full.html)
+- [CROSS JOIN](sql-ref-syntax-qry-select-join-cross.html)
+- [SEMI JOIN](sql-ref-syntax-qry-select-join-semi.html)
+- [ANTI JOIN](sql-ref-syntax-qry-select-join-anti.html)
 
 Review comment:
   I will change to one page and see how it looks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639852
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25630/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609918741
 
 
   **[Test build #120880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120880/testReport)** for PR 28121 at commit [`a2a8528`](https://github.com/apache/spark/commit/a2a8528217d615d743ea69ebfb4ce911da3815b6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610645454
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611825271
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121048/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610198662
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609952056
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609552010
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25549/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611825261
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609553837
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120855/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174701
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25588/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611345596
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121003/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404452835
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ INNER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Left Join </b><br>
+A left join returns all values from the left relation and the matched values from the right relation, or appends NULL if there is no match. It is also referred to as a left outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation LEFT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Right Join </b><br>
+A right join returns all values from the right relation and the matched values from the left relation, or appends NULL if there is no match. It is also referred to as a right outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation RIGHT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Full Join </b><br>
+A full join returns all values from both relations, appending NULL values on the side that does not have a match. It is also referred to as a full outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation FULL [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Cross Join </b><br>
+A cross join returns the Cartesian product of two relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation CROSS JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Semi Join </b><br>
+A semi join returns values from the left side of the relation that has a match with the right. It is also referred to as a left semi join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] SEMI JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Anti Join </b><br>
+An anti join returns values from the left relation that has no match with the right. It is also referred to as a left anti join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] ANTI JOIN relation [ join_criteria ]
+    </code>
+
+### Examples
+{% highlight sql %}
+-- Use employee and department tables to demonstrate different type of joins.
+SELECT * FROM employee;
+
+  +---+-----+-------+
+  |id |name |deptno |
+  +---+-----+-------+
+  |105|Chloe|5      |
+  |103|Paul |3      |
+  |101|John |1      |
+  |102|Lisa |2      |
+  |104|Evan |4      |
+  |106|Amy  |6      |
+  +---+-----+-------+
+
+SELECT * FROM department;
+  +-------+-----------+
+  |deptno |deptname   |
+  +-------+-----------+
+  |3      |Engineering|
+  |2      |Sales      |
+  |1      |Marketing  |
+  +-------+-----------+
+
+-- Use employee and department tables to demonstrate inner join.
+SELECT id, name, employee.deptno, deptname
+  FROM employee INNER JOIN department ON employee.deptno = department.deptno;
 
 Review comment:
   Ah, I see. Anything looks fine to me, but I think its better to have consistency in our SQL docs. How about following 4 spaces?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404458324
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,236 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
 
 Review comment:
   nit: the wrong indents?
   ```
     <dd>
       Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
       <b>Syntax:</b>
       <code>
         ON boolean_expression | USING ( column_name [ , column_name ... ] )
       </code> <br><br>
       <code>boolean_expression</code><br>
       Specifies an expression with a return type of boolean.
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403784784
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON booleanExpression | USING ( column_name [ , column_name ... ] )
+      </code>
+  </dd>
+</dl>
+
+### Join Types
+- [INNER JOIN](sql-ref-syntax-qry-select-join-inner.html)
+- [LEFT JOIN](sql-ref-syntax-qry-select-join-left.html)
+- [RIGHT JOIN](sql-ref-syntax-qry-select-join-right.html)
+- [FULL JOIN](sql-ref-syntax-qry-select-join-full.html)
+- [CROSS JOIN](sql-ref-syntax-qry-select-join-cross.html)
+- [SEMI JOIN](sql-ref-syntax-qry-select-join-semi.html)
+- [ANTI JOIN](sql-ref-syntax-qry-select-join-anti.html)
 
 Review comment:
   We need these individual pages for the join types? I feel most of contents (e.g., `employee` and `department`) are overlapped there...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822671
 
 
   **[Test build #121048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121048/testReport)** for PR 28121 at commit [`5ae2bf7`](https://github.com/apache/spark/commit/5ae2bf7bd453bed1529d41ab39ffca3e02705de6).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341881
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639309
 
 
   **[Test build #120938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120938/testReport)** for PR 28121 at commit [`211f2f9`](https://github.com/apache/spark/commit/211f2f929422f1180f52e346760146f957302e25).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609551826
 
 
   **[Test build #120855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120855/testReport)** for PR 28121 at commit [`4dbf2f4`](https://github.com/apache/spark/commit/4dbf2f4bca52d1effa22b1d979083589cd6f2bc0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194816
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639844
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r405134915
 
 

 ##########
 File path: docs/_data/menu-sql.yaml
 ##########
 @@ -154,7 +154,9 @@
                   url: sql-ref-syntax-qry-select-distribute-by.html
                 - text: LIMIT Clause 
                   url: sql-ref-syntax-qry-select-limit.html
-                - text: Join Hints
+                - text: JOIN
+                  url: sql-ref-syntax-qry-select-join.html
+                - text: JOIN HINTS
 
 Review comment:
   I changed to ```JOIN hints``` last night, but actually ```JOIN``` is not a SQL keyword here and shouldn't be capitalized.  I will change it back to ```Join Hints```. Sorry for changing this back and forth. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609553837
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120855/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609918963
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120880/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609558529
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609558461
 
 
   **[Test build #120856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120856/testReport)** for PR 28121 at commit [`84bc563`](https://github.com/apache/spark/commit/84bc5632fd3c08188f2c2b0d6758ff129ee955a2).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083740
 
 
   **[Test build #120813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120813/testReport)** for PR 28121 at commit [`36f44c9`](https://github.com/apache/spark/commit/36f44c9c348fa598aa3b3075b71f9aba9c39af6a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083740
 
 
   **[Test build #120813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120813/testReport)** for PR 28121 at commit [`36f44c9`](https://github.com/apache/spark/commit/36f44c9c348fa598aa3b3075b71f9aba9c39af6a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609085019
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120813/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610645454
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403785998
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
 
 Review comment:
   It already has the ```Join relation``` in the ```from_item```. I will add a link to the ```Related Clauses``` section.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404458324
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,236 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
 
 Review comment:
   nit: the format?
   ```
     <dd>
       Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
       <b>Syntax:</b>
       <code>
         ON boolean_expression | USING ( column_name [ , column_name ... ] )
       </code> <br><br>
       <code>boolean_expression</code><br>
       Specifies an expression with a return type of boolean.
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404555629
 
 

 ##########
 File path: docs/_data/menu-sql.yaml
 ##########
 @@ -154,7 +154,9 @@
                   url: sql-ref-syntax-qry-select-distribute-by.html
                 - text: LIMIT Clause 
                   url: sql-ref-syntax-qry-select-limit.html
-                - text: Join Hints
+                - text: JOIN
+                  url: sql-ref-syntax-qry-select-join.html
+                - text: JOIN HINTS
 
 Review comment:
   Fixed. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174701
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25588/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403879831
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
 
 Review comment:
   nit: remove the blank.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610177067
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120896/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822671
 
 
   **[Test build #121048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121048/testReport)** for PR 28121 at commit [`5ae2bf7`](https://github.com/apache/spark/commit/5ae2bf7bd453bed1529d41ab39ffca3e02705de6).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609084987
 
 
   **[Test build #120813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120813/testReport)** for PR 28121 at commit [`36f44c9`](https://github.com/apache/spark/commit/36f44c9c348fa598aa3b3075b71f9aba9c39af6a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611825261
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609083872
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610639852
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25630/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822995
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25739/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341505
 
 
   **[Test build #121003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121003/testReport)** for PR 28121 at commit [`ffe4e09`](https://github.com/apache/spark/commit/ffe4e0995fd249e2fc6a0334007da002c8fcf278).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403882457
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
 
 Review comment:
   nit: need intends

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609952068
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120883/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609952056
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944130
 
 
   **[Test build #120883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120883/testReport)** for PR 28121 at commit [`1318624`](https://github.com/apache/spark/commit/1318624e06edbad233d2818c2acc325ad4e4e096).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609918953
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194438
 
 
   **[Test build #120902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120902/testReport)** for PR 28121 at commit [`65d82e0`](https://github.com/apache/spark/commit/65d82e05bfee39119bf0b7c551cd1f55dbea7116).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609558536
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120856/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609552007
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610198673
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120902/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610198673
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120902/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609944720
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610198662
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611341881
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611345473
 
 
   **[Test build #121003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121003/testReport)** for PR 28121 at commit [`ffe4e09`](https://github.com/apache/spark/commit/ffe4e0995fd249e2fc6a0334007da002c8fcf278).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609085017
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609553834
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r404452835
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ INNER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Left Join </b><br>
+A left join returns all values from the left relation and the matched values from the right relation, or appends NULL if there is no match. It is also referred to as a left outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation LEFT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Right Join </b><br>
+A right join returns all values from the right relation and the matched values from the left relation, or appends NULL if there is no match. It is also referred to as a right outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation RIGHT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Full Join </b><br>
+A full join returns all values from both relations, appending NULL values on the side that does not have a match. It is also referred to as a full outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation FULL [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Cross Join </b><br>
+A cross join returns the Cartesian product of two relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation CROSS JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Semi Join </b><br>
+A semi join returns values from the left side of the relation that has a match with the right. It is also referred to as a left semi join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] SEMI JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Anti Join </b><br>
+An anti join returns values from the left relation that has no match with the right. It is also referred to as a left anti join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] ANTI JOIN relation [ join_criteria ]
+    </code>
+
+### Examples
+{% highlight sql %}
+-- Use employee and department tables to demonstrate different type of joins.
+SELECT * FROM employee;
+
+  +---+-----+-------+
+  |id |name |deptno |
+  +---+-----+-------+
+  |105|Chloe|5      |
+  |103|Paul |3      |
+  |101|John |1      |
+  |102|Lisa |2      |
+  |104|Evan |4      |
+  |106|Amy  |6      |
+  +---+-----+-------+
+
+SELECT * FROM department;
+  +-------+-----------+
+  |deptno |deptname   |
+  +-------+-----------+
+  |3      |Engineering|
+  |2      |Sales      |
+  |1      |Marketing  |
+  +-------+-----------+
+
+-- Use employee and department tables to demonstrate inner join.
+SELECT id, name, employee.deptno, deptname
+  FROM employee INNER JOIN department ON employee.deptno = department.deptno;
 
 Review comment:
   Ah, I see. Anything looks fine to me, but we need consistency in our SQL docs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609552007
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609911753
 
 
   **[Test build #120880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120880/testReport)** for PR 28121 at commit [`a2a8528`](https://github.com/apache/spark/commit/a2a8528217d615d743ea69ebfb4ce911da3815b6).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611345596
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121003/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609507936
 
 
   cc @maropu Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609555952
 
 
   **[Test build #120856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120856/testReport)** for PR 28121 at commit [`84bc563`](https://github.com/apache/spark/commit/84bc5632fd3c08188f2c2b0d6758ff129ee955a2).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610177067
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120896/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610174263
 
 
   **[Test build #120896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120896/testReport)** for PR 28121 at commit [`8be6c4a`](https://github.com/apache/spark/commit/8be6c4a12ffb783d938d91b69d6ddd1c191af75d).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611822993
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609558536
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120856/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609912414
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-611345589
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610645459
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120938/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r405153950
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,236 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
 
 Review comment:
   Not need to introduce NATURAL JOIN?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-612660821
 
 
   Merged to master/3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610176994
 
 
   **[Test build #120896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120896/testReport)** for PR 28121 at commit [`8be6c4a`](https://github.com/apache/spark/commit/8be6c4a12ffb783d938d91b69d6ddd1c191af75d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609556284
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25550/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403882457
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
 
 Review comment:
   nit: need intends

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609553834
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609551826
 
 
   **[Test build #120855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120855/testReport)** for PR 28121 at commit [`4dbf2f4`](https://github.com/apache/spark/commit/4dbf2f4bca52d1effa22b1d979083589cd6f2bc0).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609556278
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610194816
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-610645459
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120938/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609912426
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25572/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#issuecomment-609085019
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120813/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403783567
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,52 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
 
 Review comment:
   We need a link to this section from the SELECT document, too?
   https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-qry-select.md#L78-L85

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28121: [SPARK-31348][SQL][DOCS] Document Join in SQL Reference
URL: https://github.com/apache/spark/pull/28121#discussion_r403885340
 
 

 ##########
 File path: docs/sql-ref-syntax-qry-select-join.md
 ##########
 @@ -18,5 +18,222 @@ license: |
   See the License for the specific language governing permissions and
   limitations under the License.
 ---
+### Description
 
-**This page is under construction**
+A SQL join is used to combine rows from two relations based on join criteria. The following section describes the overall join syntax and the sub-sections cover different types of joins along with examples.
+
+### Syntax
+{% highlight sql %}
+
+relation { [ join_type ] JOIN relation [ join_criteria ] | NATURAL join_type JOIN relation }
+
+{% endhighlight %}
+
+### Parameters
+<dl>
+  <dt><code><em>relation</em></code></dt>
+  <dd>
+    Specifies the relation to be joined.
+  </dd>
+  <dt><code><em>join_type</em></code></dt>
+  <dd>
+    Specifies the join type.<br><br>
+    <b>Syntax:</b><br>
+      <code>
+        [ INNER ]
+        | CROSS
+        | LEFT [ OUTER ]
+        | [ LEFT ] SEMI
+        | RIGHT [ OUTER ]
+        | FULL [ OUTER ]
+        | [ LEFT ] ANTI
+      </code>
+  </dd>
+  <dt><code><em>join_criteria</em></code></dt>
+  <dd>
+    Specifies how the rows from one relation will be combined with the rows of another relation.<br><br>
+    <b>Syntax:</b>
+      <code>
+      ON boolean_expression | USING ( column_name [ , column_name ... ] )
+      </code> <br><br>
+      <code>boolean_expression</code><br>
+      Specifies an expression with a return type of boolean.
+
+  </dd>
+</dl>
+
+### Join Types
+
+- <b>Inner Join </b><br>
+The inner join is the default join in Spark. It selects rows that have matching values in both relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ INNER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Left Join </b><br>
+A left join returns all values from the left relation and the matched values from the right relation, or appends NULL if there is no match. It is also referred to as a left outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation LEFT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Right Join </b><br>
+A right join returns all values from the right relation and the matched values from the left relation, or appends NULL if there is no match. It is also referred to as a right outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation RIGHT [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Full Join </b><br>
+A full join returns all values from both relations, appending NULL values on the side that does not have a match. It is also referred to as a full outer join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation FULL [ OUTER ] JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Cross Join </b><br>
+A cross join returns the Cartesian product of two relations.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation CROSS JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Semi Join </b><br>
+A semi join returns values from the left side of the relation that has a match with the right. It is also referred to as a left semi join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] SEMI JOIN relation [ join_criteria ]
+    </code>
+
+- <b>Anti Join </b><br>
+An anti join returns values from the left relation that has no match with the right. It is also referred to as a left anti join.<br><br>
+  <b>Syntax:</b><br>
+    <code>
+    relation [ LEFT ] ANTI JOIN relation [ join_criteria ]
+    </code>
+
+### Examples
+{% highlight sql %}
+-- Use employee and department tables to demonstrate different type of joins.
+SELECT * FROM employee;
+
+  +---+-----+-------+
+  |id |name |deptno |
+  +---+-----+-------+
+  |105|Chloe|5      |
+  |103|Paul |3      |
+  |101|John |1      |
+  |102|Lisa |2      |
+  |104|Evan |4      |
+  |106|Amy  |6      |
+  +---+-----+-------+
+
+SELECT * FROM department;
+  +-------+-----------+
+  |deptno |deptname   |
+  +-------+-----------+
+  |3      |Engineering|
+  |2      |Sales      |
+  |1      |Marketing  |
+  +-------+-----------+
+
+-- Use employee and department tables to demonstrate inner join.
+SELECT id, name, employee.deptno, deptname
+  FROM employee INNER JOIN department ON employee.deptno = department.deptno;
 
 Review comment:
   nit: 2 space or 4 spaces in the head? I found 3 spaces... e.g., https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-qry-select-groupby.md#L130

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org