You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/24 00:13:35 UTC
Review Request 43914: Modified the `NetClsHandleManager` methods to
work with ranges.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles, instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On Feb. 29, 2016, 10:58 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 125-127
> > <https://reviews.apache.org/r/43914/diff/2/?file=1268101#file1268101line125>
> >
> > I think you should be able to use `foreach` here
The problem here is that we need to interate over the range stored in `Interval` which is not a container. So can't use foreach. Dropping this as per our discussion.
> On Feb. 29, 2016, 10:58 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 166-168
> > <https://reviews.apache.org/r/43914/diff/2/?file=1268101#file1268101line166>
> >
> > Ditto on using foreach
Dropping based on the above comments.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121339
-----------------------------------------------------------
On Feb. 24, 2016, 4:44 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 4:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
>
> Diff: https://reviews.apache.org/r/43914/diff/
>
>
> Testing
> -------
>
> make and make check.
>
> Also ran sudo make check for the "NetClsIsolatoTest"
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121339
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 125 - 127)
<https://reviews.apache.org/r/43914/#comment183022>
I think you should be able to use `foreach` here
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 166 - 168)
<https://reviews.apache.org/r/43914/#comment183024>
Ditto on using foreach
- Jie Yu
On Feb. 24, 2016, 4:44 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 4:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
>
> Diff: https://reviews.apache.org/r/43914/diff/
>
>
> Testing
> -------
>
> make and make check.
>
> Also ran sudo make check for the "NetClsIsolatoTest"
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
(Updated March 1, 2016, 10:17 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
addressed comments.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121484
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 125 - 129)
<https://reviews.apache.org/r/43914/#comment183199>
Can you use a nested for loop here? We might want to support non-contiguous secondaries in the future, let's write some code that's future proof.
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 166 - 169)
<https://reviews.apache.org/r/43914/#comment183200>
Ditto on using a nested for loop
- Jie Yu
On March 1, 2016, 7:58 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 7:58 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4700
> https://issues.apache.org/jira/browse/MESOS-4700
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
>
> Diff: https://reviews.apache.org/r/43914/diff/
>
>
> Testing
> -------
>
> make and make check.
>
> Also ran sudo make check for the "NetClsIsolatoTest"
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
(Updated March 1, 2016, 7:58 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
(Updated March 1, 2016, 7:55 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan
Re: Review Request 43914: Modified `NetClsHandleManager` to take a
range of secondary handles.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 4:44 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Modified `NetClsHandleManager` to take a range of secondary handles.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description (updated)
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan
Re: Review Request 43914: Modified the `NetClsHandleManager` methods
to work with ranges.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 11:18 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Added JIRA.
Bugs: MESOS-4700
https://issues.apache.org/jira/browse/MESOS-4700
Repository: mesos
Description
-------
The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
now work with a specified range of secondary handles, instead of
assuming that the entire 64K space of secondary handles is available
for use.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f
Diff: https://reviews.apache.org/r/43914/diff/
Testing
-------
make and make check.
Also ran sudo make check for the "NetClsIsolatoTest"
Thanks,
Avinash sridharan