You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/26 01:18:13 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #17953: Remove JapaneseDate related context in IntervalShardingAlgorithm
linghengqian opened a new pull request, #17953:
URL: https://github.com/apache/shardingsphere/pull/17953
For #17948.
Changes proposed in this pull request:
- Remove `java.time.chrono.JapaneseDate` related context in IntervalShardingAlgorithm due to JDK 8 limitations. Refer to https://stackoverflow.com/a/55946953 and https://bugs.openjdk.java.net/browse/JDK-8210633 .
- This is the first addition to #17948 .
- Fix LocalDate not being explicitly handled by DateTimeFormatter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #17953: Remove JapaneseDate related context in IntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #17953:
URL: https://github.com/apache/shardingsphere/pull/17953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17953: Remove JapaneseDate related context in IntervalShardingAlgorithm
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17953:
URL: https://github.com/apache/shardingsphere/pull/17953#issuecomment-1138063727
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17953](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df7db45) into [master](https://codecov.io/gh/apache/shardingsphere/commit/03bc1b7eb63d0b90c2d72b4ff0a91a7833a068f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03bc1b7) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17953 +/- ##
=========================================
Coverage 58.91% 58.91%
Complexity 2140 2140
=========================================
Files 3639 3639
Lines 54018 54018
Branches 9185 9185
=========================================
+ Hits 31825 31826 +1
Misses 19481 19481
+ Partials 2712 2711 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...m/sharding/datetime/IntervalShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/17953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2RhdGV0aW1lL0ludGVydmFsU2hhcmRpbmdBbGdvcml0aG0uamF2YQ==) | `84.37% <100.00%> (+1.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [03bc1b7...df7db45](https://codecov.io/gh/apache/shardingsphere/pull/17953?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org