You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/11 07:43:50 UTC

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4160: [INLONG-4155][Manager] Change constants in InlongGroupSettings

healchow commented on code in PR #4160:
URL: https://github.com/apache/incubator-inlong/pull/4160#discussion_r869975087


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/settings/InlongGroupSettings.java:
##########
@@ -34,9 +34,9 @@ public class InlongGroupSettings {
     /**
      * config of pulsar
      */
-    public static final String PULSAR_ADMIN_URL = "pulsar.adminUrl";
+    public static final String PULSAR_ADMIN_URL = "pulsar_adminUrl";
 
-    public static final String PULSAR_SERVICE_URL = "pulsar.serviceUrl";
+    public static final String PULSAR_SERVICE_URL = "pulsar_serviceUrl";

Review Comment:
   Wouldn't it be better to use pulsarAdminUrl and pulsarServiceUrl?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org