You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/21 14:38:19 UTC

[GitHub] [hbase] HorizonNet commented on a change in pull request #1315: HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…

HorizonNet commented on a change in pull request #1315: HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…
URL: https://github.com/apache/hbase/pull/1315#discussion_r395997896
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
 ##########
 @@ -2268,6 +2269,78 @@ public void testCheckAndMutate_WithFiltersAndTimeRange() throws Throwable {
     assertTrue(region.get(new Get(row).addColumn(FAMILY, Bytes.toBytes("A"))).isEmpty());
   }
 
+  @Test
+  public void testCheckAndMutate_wrongMutationType() throws Throwable {
 
 Review comment:
   Are there also positive test cases? The new one's only seem to catch exceptions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services