You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/18 05:32:44 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2930:
[GOBBLIN-1089] Refactor policyChecker for extensibility
autumnust opened a new pull request #2930: [GOBBLIN-1089] Refactor policyChecker for extensibility
URL: https://github.com/apache/incubator-gobblin/pull/2930
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1089
### Description
- A simple refactor for extensibility of internal use cases.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2930:
[GOBBLIN-1089] Refactor policyChecker for extensibility
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2930: [GOBBLIN-1089] Refactor policyChecker for extensibility
URL: https://github.com/apache/incubator-gobblin/pull/2930#issuecomment-600906313
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=h1) Report
> Merging [#2930](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/7252f68fc1ecd8c01cf1efc10ed57222bfbeaf35&el=desc) will **decrease** coverage by `0.95%`.
> The diff coverage is `19.04%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2930 +/- ##
============================================
- Coverage 45.57% 44.62% -0.96%
+ Complexity 9147 8976 -171
============================================
Files 1936 1936
Lines 73206 73213 +7
Branches 8080 8081 +1
============================================
- Hits 33363 32668 -695
- Misses 36749 37496 +747
+ Partials 3094 3049 -45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/qualitychecker/row/RowLevelPolicyChecker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Jvdy9Sb3dMZXZlbFBvbGljeUNoZWNrZXIuamF2YQ==) | `35.80% <0.00%> (-1.86%)` | `3.00 <0.00> (ø)` | |
| [...alitychecker/row/RowLevelPolicyCheckerBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Jvdy9Sb3dMZXZlbFBvbGljeUNoZWNrZXJCdWlsZGVyLmphdmE=) | `80.00% <100.00%> (+1.87%)` | `8.00 <3.00> (+2.00)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `0.00% <0.00%> (-80.77%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lin/runtime/locks/LegacyJobLockFactoryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvTGVnYWN5Sm9iTG9ja0ZhY3RvcnlNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apache/gobblin/metastore/ZkStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-2.00%)` | |
| [...he/gobblin/runtime/ZkDatasetStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2930/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=footer). Last update [7252f68...ef8f5cc](https://codecov.io/gh/apache/incubator-gobblin/pull/2930?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2930:
[GOBBLIN-1089] Refactor policyChecker for extensibility
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2930: [GOBBLIN-1089] Refactor policyChecker for extensibility
URL: https://github.com/apache/incubator-gobblin/pull/2930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2930: [GOBBLIN-1089] Refactor policyChecker for extensibility
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #2930: [GOBBLIN-1089] Refactor policyChecker for extensibility
URL: https://github.com/apache/incubator-gobblin/pull/2930#discussion_r395161522
##########
File path: gobblin-core/src/main/java/org/apache/gobblin/qualitychecker/row/RowLevelPolicyChecker.java
##########
@@ -102,25 +102,35 @@ public boolean executePolicies(Object record, RowLevelPolicyCheckResults results
for (RowLevelPolicy p : this.list) {
RowLevelPolicy.Result result = p.executePolicy(record);
results.put(p, result);
+ if (!handleCheckResult(result, p, record)) {
+ return false;
+ }
+ }
+ return true;
+ }
- if (result.equals(RowLevelPolicy.Result.FAILED)) {
- if (p.getType().equals(RowLevelPolicy.Type.FAIL)) {
- throw new RuntimeException("RowLevelPolicy " + p + " failed on record " + record);
- } else if (p.getType().equals(RowLevelPolicy.Type.ERR_FILE)) {
- if (this.sampler.acceptNext()) {
- if (!this.errFileOpen) {
- this.writer.open(getErrFilePath(p));
- this.writer.write(record);
- } else {
- this.writer.write(record);
- }
- this.errFileOpen = true;
+ /**
+ * Handle the result of {@link RowLevelPolicy#executePolicy(Object)}
+ */
+ protected boolean handleCheckResult(RowLevelPolicy.Result checkResult, RowLevelPolicy p, Object record) throws IOException {
Review comment:
handleCheckResult -> checkResult?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services