You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "acassis (via GitHub)" <gi...@apache.org> on 2023/06/15 12:31:25 UTC
[GitHub] [nuttx] acassis commented on a diff in pull request #9521: fs: move memset to upper lever for statfs and add f_fsid field
acassis commented on code in PR #9521:
URL: https://github.com/apache/nuttx/pull/9521#discussion_r1230937936
##########
include/sys/statfs.h:
##########
@@ -114,6 +114,10 @@ struct statfs
fsblkcnt_t f_bavail; /* Free blocks avail to non-superuser */
fsfilcnt_t f_files; /* Total file nodes in the file system */
fsfilcnt_t f_ffree; /* Free file nodes in the file system */
+ struct
+ {
+ int val[2];
+ } f_fsid; /* Encode device type, not yet in use */
Review Comment:
I think it is not common to have a struct defined inside other struct on NuttX, shouldn't it better to define f_fsid as f_fsid_s outside of statfs struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org