You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 19:41:44 UTC

[GitHub] [airflow] ryanahamilton commented on a diff in pull request #22866: Fix Grid view font sizing

ryanahamilton commented on code in PR #22866:
URL: https://github.com/apache/airflow/pull/22866#discussion_r846427491


##########
airflow/www/static/js/tree/details/Header.jsx:
##########
@@ -72,22 +73,22 @@ const Header = () => {
   const isTaskDetails = runId && taskId;
 
   return (
-    <Breadcrumb color="gray.300" mt={4}>
+    <Breadcrumb mt={4} separator={<Text color="gray.300">/</Text>}>

Review Comment:
   I'm not exactly sure what your compile markup looks like, but I'd guess you don't actually need/want a `<p></p>`?
   ```suggestion
       <Breadcrumb mt={4} separator={<Box as="span" color="gray.300">/</Box>}>
   ```



##########
airflow/www/static/js/tree/index.jsx:
##########
@@ -51,11 +51,21 @@ const queryClient = new QueryClient({
   },
 });
 
+const theme = extendTheme({
+  components: {
+    Tooltip: {
+      baseStyle: {
+        fontSize: 'md',
+      },
+    },
+  },
+});
+

Review Comment:
   When/if this gets larger, we'd probably want to move it to a dedicated file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org