[GitHub] [incubator-druid] leventov commented on a change in pull request #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8700: In DirectDruidClient, don't run Future cancellation listener in HTTP library executor
URL: https://github.com/apache/incubator-druid/pull/8700#discussion_r341676776
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java
 ##########
 @@ -465,38 +469,49 @@ public void onFailure(Throwable t)
             {
               openConnections.getAndDecrement();
               if (future.isCancelled()) {
-                // forward the cancellation to underlying queriable node
+                cancel();
+              }
+            }
+
+            private void cancel()
 
 Review comment:
   I'd call this method a little more specific: `cancelQuery()` and move up: make it a method of `DirectDruidClient`, to reduce internal indentation/nesting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org