You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "Haacked (JIRA)" <ji...@apache.org> on 2006/08/08 09:40:16 UTC

[jira] Commented: (LOG4NET-88) [PATCH] to AdoNetAppender.cs to support .NET 2.0 connectionStrings configuration section

    [ http://issues.apache.org/jira/browse/LOG4NET-88?page=comments#action_12426492 ] 
            
Haacked commented on LOG4NET-88:
--------------------------------

I applied this against the trunk (version 1.2.10.0) Subversion revision number 429549.


I didn't notice the option to grant license to ASF but I hereby Grant license to the patch to ASF for inclusion in ASF works.

> [PATCH] to AdoNetAppender.cs to support .NET 2.0 connectionStrings configuration section
> ----------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-88
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-88
>             Project: Log4net
>          Issue Type: Improvement
>          Components: Appenders
>    Affects Versions: 1.2.10
>         Environment: Windows XP .NET 2.0
>            Reporter: Haacked
>         Attachments: AdoNetAppenderConnectionStringName.patch
>
>
> This is a patch for [LOG4NET-78] https://issues.apache.org/jira/browse/LOG4NET-78.  This adds a new "connectionStringName" attribute (and corresponding ConnectionStringName) property to the AdoNetAppender class.  This is a reference to a connection string within the <ConnectionStrings> section of an App.config or Web.config file.
> The choice of name "connectionStringName" is consistent with the naming that Microsoft uses in the various Providers such as SqlMembershipProvider.
> I made sure to put this code in between #if NET_2_0 blocks. However, the patch does not include the required change to the log4net.csproj file which needs to reference the System.Configuration.dll (C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.configuration.dll) assembly.  
> This is a .NET 2.0 only assembly so I was unsure how to add a conditional compilation element so that the project reference would not break log4net for .NET 1.0 and .NET 1.1.  
> If there is a better way to do so, please let me know!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira