[GitHub] [apisix] lingliy commented on a diff in pull request #9298: fix(wolf-rbac): other plugin in consumer not effective when consumer used wolf-rbac plugin (#9287)

["lingliy (via GitHub)" <gi...@apache.org>]

lingliy commented on code in PR #9298:
URL: https://github.com/apache/apisix/pull/9298#discussion_r1185290588


##########
t/plugin/wolf-rbac.t:
##########
@@ -685,3 +685,55 @@ passed
             ngx.status = code
         }
     }
+
+
+
+=== TEST 36: add consumer with echo plugin
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local code, body = t('/apisix/admin/consumers',
+                ngx.HTTP_PUT,
+                [[{
+                    "username": "wolf_rbac_with_other_plugins",
+                    "plugins": {
+                        "wolf-rbac": {
+                            "appid": "wolf-rbac-app",
+                            "server": "http://127.0.0.1:1982"
+                        },
+                        "echo": {
+                            "body": "consumer merge echo plugins\n"

Review Comment:
   I want to avoid having one plugin dependent on another, and I think echo is a much more basic plugin.
   
   after a brief review of ci errors, it seems that many errors have nothing to do with this modification. when I am free, I will have a careful look



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org