[GitHub] [spark] chenzhx commented on a diff in pull request #37169: [SPARK-38901][SQL] DS V2 supports push down misc functions

[GitBox <gi...@apache.org>]

chenzhx commented on code in PR #37169:
URL: https://github.com/apache/spark/pull/37169#discussion_r920122167


##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -1115,6 +1115,69 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
     checkAnswer(df8, Seq(Row("alex")))
   }
 
+  test("scan with filter push-down with misc functions") {
+    Seq(false, true).foreach { ansiMode =>
+      withSQLConf(SQLConf.ANSI_ENABLED.key -> ansiMode.toString) {

Review Comment:
   Because MD5 and SHA functions need to convert name to binary type, cast will be added.
   So we need test ANSI_ENABLED.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org