Re: svn commit: r111887 - in cocoon/site/src/documentation/content/xdocs: . community devinfo

[Vadim Gritsenko <va...@reverycodes.com>]

upayavira@apache.org wrote:
> 
> @@ -31,17 +31,17 @@
>      <section id="whitespace">
>        <title>Consistent whitespace</title>
>        <p>
> -        Whitespace can cause big problems with CVS. If it is inconsistent,
> +        Whitespace can cause big problems with SVN. If it is inconsistent,
>          then diffs are very hard to follow - actual changes become lost in
>          the noise of whitespace changes. Some developers use editors that
>          attempt to automatically format the whitespace. The trouble is
> -        that if CVS files are inconsistent, some of those editors just
> +        that if SVN files are inconsistent, some of those editors just
>          make it worse.
>        </p>
...
> @@ -75,7 +75,7 @@
>        <p>
>          If you are on a UNIX system, when you receive a patch from a
>          contributor on Windows then do a 'dos2unix'. If you are on a
> -        Windows system, then ensure that you have a proper CVS client
> +        Windows system, then ensure that you have a proper SVN client
>          (it is supposed to convert to UNIX line-endings when you commit).
>        </p>

IIUC, all of the above is not relevant for SVN as long as svn:eol-type property 
is set... Can somebody confirm?

Vadim

Re: svn commit: r111887 - in cocoon/site/src/documentation/content/xdocs: . community devinfo

[David Crossley <cr...@apache.org>]

Upayavira wrote:
> Tony Collen wrote:
> >Vadim Gritsenko wrote:
> >>
> >>IIUC, all of the above is not relevant for SVN as long as 
> >>svn:eol-type property is set... Can somebody confirm?
> >
> >Perhaps a note about how to set this property in svn would be useful :)
> 
> I did think about this when writing, but don't know how to do it. So, 
> anyone, either update the page, or let me know here what this prop stuff 
> is all about, and I'l update the page.

The question was answered at general@gump yesterday. I will put a document
at www.apache.org/dev/ to explain for everyone.

--David

Re: svn commit: r111887 - in cocoon/site/src/documentation/content/xdocs: . community devinfo

[Upayavira <uv...@upaya.co.uk>]

Tony Collen wrote:

> Vadim Gritsenko wrote:
>
>>
>>
>> IIUC, all of the above is not relevant for SVN as long as 
>> svn:eol-type property is set... Can somebody confirm?
>>
>> Vadim
>
>
> Perhaps a note about how to set this property in svn would be useful :)

I did think about this when writing, but don't know how to do it. So, 
anyone, either update the page, or let me know here what this prop stuff 
is all about, and I'l update the page.

Regards, Upayavira

Re: svn commit: r111887 - in cocoon/site/src/documentation/content/xdocs: . community devinfo

[Tony Collen <co...@umn.edu>]

Vadim Gritsenko wrote:

> 
> 
> IIUC, all of the above is not relevant for SVN as long as svn:eol-type 
> property is set... Can somebody confirm?
> 
> Vadim

Perhaps a note about how to set this property in svn would be useful :)

Tony

Re: svn commit: r111887 - in cocoon/site/src/documentation/content/xdocs: . community devinfo

[David Crossley <cr...@apache.org>]

Vadim Gritsenko wrote:
> upayavira wrote:
> >
> >@@ -31,17 +31,17 @@
> >     <section id="whitespace">
> >       <title>Consistent whitespace</title>
> >       <p>
> >-        Whitespace can cause big problems with CVS. If it is inconsistent,
> >+        Whitespace can cause big problems with SVN. If it is inconsistent,
> >         then diffs are very hard to follow - actual changes become lost in
> >         the noise of whitespace changes. Some developers use editors that
> >         attempt to automatically format the whitespace. The trouble is
> >-        that if CVS files are inconsistent, some of those editors just
> >+        that if SVN files are inconsistent, some of those editors just
> >         make it worse.
> >       </p>
> ...
> >@@ -75,7 +75,7 @@
> >       <p>
> >         If you are on a UNIX system, when you receive a patch from a
> >         contributor on Windows then do a 'dos2unix'. If you are on a
> >-        Windows system, then ensure that you have a proper CVS client
> >+        Windows system, then ensure that you have a proper SVN client
> >         (it is supposed to convert to UNIX line-endings when you commit).
> >       </p>
> 
> IIUC, all of the above is not relevant for SVN as long as svn:eol-type 
> property is set... Can somebody confirm?

Yes it is definitely all still relevant. The committer has to clear up
the line endings to be relevant to their own operating system then
svn add myfile.txt
svn propset svn:eol-style native myfile.txt

... or set your svn client to detect common filename extensions and
automatically set that property.

--David