[jira] [Commented] (HBASE-21168) BloomFilterUtil uses hardcoded randomness

["Mingliang Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607454#comment-16607454 ] 

Mingliang Liu commented on HBASE-21168:
---------------------------------------

+1 (non-binding)

Nits nits: {{setFakeLookupMode}} can be renamed {{setRandomGeneratorForTest}} as the "mode" is not clear any more. Or add javadoc to indicate the null behavior. Better to have clarifying parentheses as {{int hashLoc = (randomGeneratorForTest == null)}}

> BloomFilterUtil uses hardcoded randomness
> -----------------------------------------
>
>                 Key: HBASE-21168
>                 URL: https://issues.apache.org/jira/browse/HBASE-21168
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-21168.master.001.patch
>
>
> This was flagged by a Fortify scan and while it doesn't appear to be a real issue, it's pretty easy to take care of anyway.
> The hard coded rand can be moved to the test class that actually needs it to make the static analysis happy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)