You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/19 17:08:33 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #7062: Improve handling of bytes data

villebro opened a new pull request #7062: Improve handling of bytes data
URL: https://github.com/apache/incubator-superset/pull/7062
 
 
   This is a continuation of #6987 which caused a regression when selecting non-`utf-8` bytes data on Postgres. Also improves and harmonizes rendering of `utf-8` compliant bytes data when possible.
   
   # Before
   - Postgres `utf-8` bytes data: `🐍` shows up as `🐍`
   - Postgres non-`utf-8` bytes data: `åäöÅÄÖ` encoded as `latin-1` throws exception
   - Regular `utf-8` bytes data: `🐍` shows up as `b'\\xf0\\x9f\\x90\\x8d'`
   - Regular non-`utf-8` bytes data: `åäöÅÄÖ` encoded as `latin-1` shows up as 'b'\\xe5\\xe4\\xf6\\xc5\\xc4\\xd6''
   
   # After
   - Postgres `utf-8` bytes data: `🐍` shows up as `🐍`
   - Postgres non-`utf-8` bytes data: `åäöÅÄÖ` encoded as `latin-1` shows up as `[bytes]`
   - Regular `utf-8` bytes data: `🐍` shows up as `🐍`
   - Regular non-`utf-8` bytes data: `åäöÅÄÖ` encoded as `latin-1` shows up as `[bytes]`
   
   <img width="744" alt="Screenshot 2019-03-19 at 19 07 13" src="https://user-images.githubusercontent.com/33317356/54626646-42482280-4a7a-11e9-8db7-0c4e37e86e46.png">
   
   Ping @mistercrunch  @john-bodley @mmuru 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org