[GitHub] [flink] zentol commented on a change in pull request #10197: [FLINK-14503][coordination] Add partition report to heartbeat

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #10197: [FLINK-14503][coordination] Add partition report to heartbeat
URL: https://github.com/apache/flink/pull/10197#discussion_r349084393
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partition/ClusterPartitionReport.java
 ##########
 @@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.taskexecutor.partition;
+
+import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
+import org.apache.flink.runtime.jobgraph.IntermediateDataSetID;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Set;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * A report about the current status of all cluster partitions of the TaskExecutor, describing
+ * which partitions are available.
+ */
+public class ClusterPartitionReport implements Serializable {
+
+	private static final long serialVersionUID = -3150175198722481689L;
+
+	private final Collection<ClusterPartitionReportEntry> entries;
+
+	public ClusterPartitionReport(final Collection<ClusterPartitionReportEntry> entries) {
+		this.entries = checkNotNull(entries);
+	}
+
+	public Collection<ClusterPartitionReportEntry> getEntries() {
+		return entries;
+	}
+
+	@Override
+	public String toString() {
+		return "PartitionReport{" +
+			"entries=" + entries +
+			'}';
+	}
+
+	/**
+	 * An entry describing all partitions belonging to one dataset.
+	 */
+	public static class ClusterPartitionReportEntry implements Serializable {
+
+		private static final long serialVersionUID = -666517548300250601L;
+
+		private final IntermediateDataSetID dataSetId;
 
 Review comment:
   I intentionally did not want to couple the reporter to TE internal classes, particularly so since the TEPI has specific hashcode/equals implementations that may introduce subtle issues down the line if it were re-used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services