[GitHub] [rocketmq] hzh0425 commented on a diff in pull request #4212: [ISSUE #4211] Fix diskMaxUsedSpaceRatio does not take effect in dLedger

[GitBox <gi...@apache.org>]

hzh0425 commented on code in PR #4212:
URL: https://github.com/apache/rocketmq/pull/4212#discussion_r858454980


##########
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java:
##########
@@ -101,6 +101,8 @@ public DLedgerCommitLog(final DefaultMessageStore defaultMessageStore) {
         dLedgerConfig.setFileReservedHours(defaultMessageStore.getMessageStoreConfig().getFileReservedTime() + 1);
         dLedgerConfig.setPreferredLeaderId(defaultMessageStore.getMessageStoreConfig().getPreferredLeaderId());
         dLedgerConfig.setEnableBatchPush(defaultMessageStore.getMessageStoreConfig().isEnableBatchPush());
+        dLedgerConfig.setDiskSpaceRatioToCheckExpired(defaultMessageStore.getMessageStoreConfig().getDiskMaxUsedSpaceRatio());

Review Comment:
   Should you add a new parameter instead of sharing the same one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org