You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/20 02:48:09 UTC
[GitHub] [camel-k] doru1004 opened a new pull request #1924: Fix modeline for inspect.
doru1004 opened a new pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924
<!-- Description -->
Enable modeline options for inspect command.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Enable modeline support for inspect.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764633428
@apupier there is a flaky e2e that fails from time to time, and that we need to investigate. I've relaunched the failing job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764663531
@apupier I had a look at the error too but it doesn't look like it's related to this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-763701047
> I think it would be useful to provide tests for the various additional use cases:
>
> * modeline-specified dependency added using mvn notation
> * modeline-specified dependency added using "simple" notation for a camel component
> * modeline-specified dependency added using jitpack notation
> * several modeline-specified dependencies written on several lines
I have added some tests. The value of the dependency does not matter at this point. What we were missing for modeline is the addition of these dependencies when inspect was used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764663531
@apupier I had a look at the error too but it doesn't look like it's related to this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764633428
@apupier there is a flaky e2e that fails from time to time, and that we need to investigate. I've relaunched the failing job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] apupier commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764621254
any ideas why it is failing? https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2538
```
--- PASS: TestIntegrationUpgrade (71.05s)
FAIL
FAIL github.com/apache/camel-k/e2e/common 1235.005s
FAIL
Error: Makefile:149: recipe for target 'test-integration' failed
make: *** [test-integration] Error 1
Error: Process completed with exit code 2.
```
https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2127
```
Error: dump.go:147: > 2021-01-20 16:29:32,520 ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): org.apache.camel.NoSuchEndpointException: No endpoint could be found for: cron://tab?schedule=0/1+*+*+*+*+?, please check your classpath contains the needed Camel component jar.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] apupier commented on pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
apupier commented on pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924#issuecomment-764621254
any ideas why it is failing? https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2538
```
--- PASS: TestIntegrationUpgrade (71.05s)
FAIL
FAIL github.com/apache/camel-k/e2e/common 1235.005s
FAIL
Error: Makefile:149: recipe for target 'test-integration' failed
make: *** [test-integration] Error 1
Error: Process completed with exit code 2.
```
https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2127
```
Error: dump.go:147: > 2021-01-20 16:29:32,520 ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): org.apache.camel.NoSuchEndpointException: No endpoint could be found for: cron://tab?schedule=0/1+*+*+*+*+?, please check your classpath contains the needed Camel component jar.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #1924: Fix modeline for inspect.
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #1924:
URL: https://github.com/apache/camel-k/pull/1924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org