[GitHub] [superset] zhaoyongjie commented on a diff in pull request #24278: feat: update makefile with new commands

["zhaoyongjie (via GitHub)" <gi...@apache.org>]

zhaoyongjie commented on code in PR #24278:
URL: https://github.com/apache/superset/pull/24278#discussion_r1217928636


##########
Makefile:
##########
@@ -115,3 +115,21 @@ report-celery-beat:
 
 admin-user:
 	superset fab create-admin
+
+# Create a postgres instance using docker
+# CLI: $ psql postgresql://postgres:1234@localhost:5432/postgres
+# superset_config.py: SQLALCHEMY_DATABASE_URI = 'postgresql://postgres:1234@localhost:5432/postgres'
+db:
+	# start postgres with detached mode
+	docker run -d -p 127.0.0.1:5432:5432 -e POSTGRES_PASSWORD="1234" --name pg postgres:alpine;\

Review Comment:
   Any plaintext passwords should be avoided as much as possible, at least, providing an approach that the password pass from a command parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org