You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/18 13:39:35 UTC

[GitHub] [arrow-rs] alamb opened a new pull request #1199: Revert "update nightly version for miri (#1189)"

alamb opened a new pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199


   
   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-rs/issues/1198
   
   # Rationale for this change
    Master CI checks seem to be broken
   
   # What changes are included in this PR?
   This reverts commit 548c96101e9f9cb06099a630d7d58f6a4e70f2f9.
   
   
   # Are there any user-facing changes?
   
   No (this just controls what version of Rust is used in CI checks)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015507185


   Yeah I agree that the upgrade of nightly version doesn't seem to have caused this issue; 
   All the checks passed on https://github.com/apache/arrow-rs/pull/1189 -- https://github.com/apache/arrow-rs/pull/1189/checks
   
   I suspect that this is related to some crate being released that was not actually 'semver' compatible in some way


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] gangliao commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
gangliao commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015468728


   ```bash
   11s
   Run rustup toolchain install nightly
   info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
   info: latest update on 2022-01-18, rust version 1.60.0-nightly (ee5d8d37b 2022-01-17)
   info: downloading component 'cargo'
   info: downloading component 'rust-std'
   info: downloading component 'rustc'
   info: installing component 'cargo'
   info: installing component 'rust-std'
   info: installing component 'rustc'
   
     nightly-x86_64-unknown-linux-gnu installed - rustc 1.60.0-nightly (ee5d8d37b 2022-01-17)
   
   info: checking for self-updates
   info: using existing install for 'nightly-x86_64-unknown-linux-gnu'
   
   info: default toolchain set to 'nightly-x86_64-unknown-linux-gnu'
     nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.60.0-nightly (ee5d8d37b 2022-01-17)
   
   info: downloading component 'rustfmt'
   info: installing component 'rustfmt'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Jimexist commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015502331


   thanks for the change. in my opinion it was hardly the reason. either way just bumping a nightly version in CI wouldn't be the cause of a breakage (if it were, it were merely exposing a false negative).
   
   i remember we had a good fight with miri some months ago. at the end @alamb you had to disable miri for a while...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] gangliao commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
gangliao commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015468085


   It still installs the latest nightly code: https://github.com/apache/arrow-rs/runs/4853953542?check_suite_focus=true#step:6:7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015461031


   🤔  this did not seem to solve the problem either. Will have to dig deeper maybe later today if no one beats me to it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1199: Revert "update nightly version for miri (#1189)"

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1199:
URL: https://github.com/apache/arrow-rs/pull/1199#issuecomment-1015440718


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1199](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f615cb) into [master](https://codecov.io/gh/apache/arrow-rs/commit/0cc0c055e0fb09553fa80186768f9b539a552419?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cc0c05) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 4f615cb differs from pull request most recent head 1dfd04a. Consider uploading reports for the commit 1dfd04a to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/1199/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1199   +/-   ##
   =======================================
     Coverage   82.67%   82.68%           
   =======================================
     Files         175      175           
     Lines       51561    51561           
   =======================================
   + Hits        42630    42632    +2     
   + Misses       8931     8929    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.43% <0.00%> (+0.22%)` | :arrow_up: |
   | [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1199/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (+0.42%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0cc0c05...1dfd04a](https://codecov.io/gh/apache/arrow-rs/pull/1199?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org