You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2006/03/15 18:29:04 UTC
svn commit: r386120 -
/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Author: remm
Date: Wed Mar 15 09:29:02 2006
New Revision: 386120
URL: http://svn.apache.org/viewcvs?rev=386120&view=rev
Log:
- As suggested by Peter, move getWorkerThread inside the try (an OOM could occur). This isn't going
to help the server much, though.
Modified:
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=386120&r1=386119&r2=386120&view=diff
==============================================================================
--- tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java Wed Mar 15 09:29:02 2006
@@ -900,11 +900,10 @@
}
}
- // Allocate a new worker thread
- Worker workerThread = getWorkerThread();
-
- // Accept the next incoming connection from the server socket
try {
+ // Allocate a new worker thread
+ Worker workerThread = getWorkerThread();
+ // Accept the next incoming connection from the server socket
long socket = Socket.accept(serverSock);
// Hand this socket off to an appropriate processor
if (setSocketOptions(socket)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r386120 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Posted by Peter Rossbach <pr...@objektpark.de>.
Thanks, :-)
Peter
Am 15.03.2006 um 18:29 schrieb remm@apache.org:
> Author: remm
> Date: Wed Mar 15 09:29:02 2006
> New Revision: 386120
>
> URL: http://svn.apache.org/viewcvs?rev=386120&view=rev
> Log:
> - As suggested by Peter, move getWorkerThread inside the try (an
> OOM could occur). This isn't going
> to help the server much, though.
>
> Modified:
> tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/
> AprEndpoint.java
>
> Modified: tomcat/connectors/trunk/util/java/org/apache/tomcat/util/
> net/AprEndpoint.java
> URL: http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/
> java/org/apache/tomcat/util/net/AprEndpoint.java?
> rev=386120&r1=386119&r2=386120&view=diff
> ======================================================================
> ========
> --- tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/
> AprEndpoint.java (original)
> +++ tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/
> AprEndpoint.java Wed Mar 15 09:29:02 2006
> @@ -900,11 +900,10 @@
> }
> }
>
> - // Allocate a new worker thread
> - Worker workerThread = getWorkerThread();
> -
> - // Accept the next incoming connection from the
> server socket
> try {
> + // Allocate a new worker thread
> + Worker workerThread = getWorkerThread();
> + // Accept the next incoming connection from
> the server socket
> long socket = Socket.accept(serverSock);
> // Hand this socket off to an appropriate
> processor
> if (setSocketOptions(socket)) {
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org