You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2014/07/07 17:30:34 UTC

[jira] [Commented] (OAK-1945) Unclear NodeStore.merge() contract

    [ https://issues.apache.org/jira/browse/OAK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053756#comment-14053756 ] 

Alex Parvulescu commented on OAK-1945:
--------------------------------------

I guess it makes sense. how do I go about OAK-1946 then?

> Unclear NodeStore.merge() contract
> ----------------------------------
>
>                 Key: OAK-1945
>                 URL: https://issues.apache.org/jira/browse/OAK-1945
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alex Parvulescu
>         Attachments: MergeTest.java.patch
>
>
> The SegmentMK doesn't respect the #merge contract when there is a builder that has no local changes passed in.
> This popped-up while I was reworking the restore parts and with the new compaction code, the only option is to pass in a NodeState#Builder builder which is considered by the #merge method as a noop and therefore ignored.
> (update: See comments below)



--
This message was sent by Atlassian JIRA
(v6.2#6252)