You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/21 10:59:41 UTC
[GitHub] [iotdb] cigarl opened a new pull request, #5235: [IOTDB-2743] ttl cannot be set if storage group is not exist
cigarl opened a new pull request, #5235:
URL: https://github.com/apache/iotdb/pull/5235
<img width="267" alt="1647317336" src="https://user-images.githubusercontent.com/44458757/158304597-ad0079f6-f3ff-41bf-b8e1-955f0d3284fc.png">
We should tell the user that they are using the wrong storage group,then let them troubleshoot the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl commented on pull request #5235: [IOTDB-2743] ttl cannot be set if storage group is not exist
Posted by GitBox <gi...@apache.org>.
cigarl commented on PR #5235:
URL: https://github.com/apache/iotdb/pull/5235#issuecomment-1105955958
@HTHou @wangchao316
Sorry, i just got back from other threads.I reviewed the issue and there are two major changes:
a. The related unit tests bypass the `planExecutor` and validate the `LocalSchemaProcessor` directly.
b. The test for TTL in `IoTDBTtlIT` catches the exception as a `TIMESERIES_NOT_EXIST`, which is obviously not correct.
PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl closed pull request #5235: [IOTDB-2743] ttl cannot be set if storage group is not exist
Posted by GitBox <gi...@apache.org>.
cigarl closed pull request #5235: [IOTDB-2743] ttl cannot be set if storage group is not exist
URL: https://github.com/apache/iotdb/pull/5235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org