You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/10 19:07:22 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
mattyb149 opened a new pull request #4519:
URL: https://github.com/apache/nifi/pull/4519
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
When using Kerberos and a load balancer to connect to a database, it is possible for DBCPConnectionPool to return a connection to the load balancer but logged in with the wrong ticket for the target database (this happens in High Availability scenarios). This PR tries to relogin to Kerberos if an exception occurs during connect.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-691222242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-694387302
+1 changes look good, going to merge, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-691222242
I force-pushed to make cherry-picking easier, all I did for the "second commit" was to move the Mock object into its own module under nifi-extension-utils as you suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module.
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
That makes sense, will move this into a new module. It used to be only in the Hive 3 module but I needed to add it somewhere else too so rather than copy I thought to reuse it. That might happen in the future as well so a new module is a good idea, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende merged pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
bbende merged pull request #4519:
URL: https://github.com/apache/nifi/pull/4519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-691222242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
<artifactId>nifi-data-provenance-utils</artifactId>
<version>1.13.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </dependency>
Review comment:
I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api.
I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org