You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/25 20:36:28 UTC
[kudu-CR] [java] Upgrade to Gradle 4.7
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10206
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
[java] Upgrade to Gradle 4.7
Our build is broken on Gradle 4.7. This patch fixes that issue
and upgrades the wrapper version to 4.7.
Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
---
M java/gradle/dependencies.gradle
M java/gradle/docs.gradle
M java/gradlew
3 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10206/1
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:32:16 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 01:41:51 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew@84
PS1, Line 84: curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v4.7.0/gradle/wrapper/gradle-wrapper.jar
> This actual jar version isn't very important. It just contains the logic fo
hmm, ok. I could have sworn on my machine I had gradle output telling me I was using an older gradle compared to what the files indicated I should have been using (4.2 vs 4.6 or somesuch).
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:26:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
[java] Upgrade to Gradle 4.7
Our build is broken on Gradle 4.7. This patch fixes that issue
and upgrades the wrapper version to 4.7.
Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Reviewed-on: http://gerrit.cloudera.org:8080/10206
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/dependencies.gradle
M java/gradle/docs.gradle
M java/gradlew
3 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew@84
PS1, Line 84: curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v4.7.0/gradle/wrapper/gradle-wrapper.jar
> I noticed on my machine that I had an old gradlew locally from a different
This actual jar version isn't very important. It just contains the logic for grabbing the actual distribution which hasn't changed.
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:14:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew@84
PS1, Line 84: curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v4.7.0/gradle/wrapper/gradle-wrapper.jar
I noticed on my machine that I had an old gradlew locally from a different branch. Perhaps we should be doing something a little smarter here to ensure that it actually upgrades aggressively even if there is an existing checkout?
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 25 Apr 2018 22:13:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 4.7
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10206 )
Change subject: [java] Upgrade to Gradle 4.7
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/10206/1/java/gradlew@84
PS1, Line 84: curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v4.7.0/gradle/wrapper/gradle-wrapper.jar
> hmm, ok. I could have sworn on my machine I had gradle output telling me I
I figured this out. It's the gradle-wrapper.properties that we are not being smart enough about. This is the file that defines the wrapper distribution version to use.
I will put up a patch to make this better.
--
To view, visit http://gerrit.cloudera.org:8080/10206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I091244886374fef6c9a0ada97b4c3e0693848e16
Gerrit-Change-Number: 10206
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 01:54:14 +0000
Gerrit-HasComments: Yes