You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/05/18 15:12:41 UTC

[GitHub] [incubator-tubemq] viviel opened a new pull request #85: [TUBEMQ-127] Fixed a bug & minor changes

viviel opened a new pull request #85:
URL: https://github.com/apache/incubator-tubemq/pull/85


   1. Fixed a bug
   Syntax error
   ```
   map.keySet().iterator(); (1.8 syntax) -> new ArrayList<>(map.keySet()).iterator();
   ```
   
   2. Minor changes
   ```
   if (curToken != null && curToken == usedToken) {
       return true;
   }
   
   change to
   
   return curToken != null && curToken == usedToken;
   ```
   
   ```
   if (isReged == null) {
       return true;
   }
   
   change to
   
   return isReged == null;
   ```
   
   ```
   List<String> partKeys = new ArrayList<>();
   partKeys.addAll(partitionUsedMap.keySet());
   
   change to
   
   List<String> partKeys = new ArrayList<>(partitionUsedMap.keySet());
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #85: [TUBEMQ-127] Fixed a bug & minor changes

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #85:
URL: https://github.com/apache/incubator-tubemq/pull/85


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org