You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/11/17 04:12:12 UTC
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
GitHub user babokim opened a pull request:
https://github.com/apache/tajo/pull/247
TAJO-1122: Refactor the tajo-storage project structure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/babokim/tajo TAJO-1122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit b6e372108d293d8af76185c475b592b10dac012e
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-23T07:31:57Z
TAJO-1123: Use Fragment instead of FileFragment.
commit ec11bef177e5b95ac8842df465ff111759cec501
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-24T10:26:52Z
TAJO-1127: Implements HBaseStorageManager
Implements HBaseStorageManager and HBaseScanner.
commit 6b9e57c761dd613b0455824452de27e2bcee930f
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-24T16:42:39Z
TAJO-1127: Implements HBaseStorageManager
Implements non-forward query.
commit eb2e8ecef5ac344d3286aa8d227b25489c6b4273
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-25T10:12:59Z
TAJO-1127: Implements HBaseStorageManager.
commit d1ccd12ceefceef5c5505fb64e5271d475d6927e
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-26T20:40:04Z
Merge branch 'hbase_storage' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1123
Conflicts:
tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
commit d7198b5a028283a012fbcffe0bc6fde7ee93360c
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-26T21:26:11Z
Merge branch 'TAJO-1123' of https://github.com/babokim/tajo into TAJO-1127
Conflicts:
tajo-core/src/main/java/org/apache/tajo/master/NonForwardQueryResultScanner.java
tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java
tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
commit 77941b843c99786e4eafd26b8d4d32f5349c38aa
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-10-27T06:20:34Z
TAJO-1127: Implements HBaseStorageManager.
commit cdfe6de1dac146d9a4f8731e65558b21b21a5b24
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-10-27T06:55:12Z
Merge branch 'hbase_storage' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1127
Conflicts:
tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
tajo-core/src/main/java/org/apache/tajo/master/LazyTaskScheduler.java
tajo-core/src/main/java/org/apache/tajo/master/NonForwardQueryResultScanner.java
tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
tajo-storage/src/main/java/org/apache/tajo/storage/FileStorageManager.java
tajo-storage/src/main/java/org/apache/tajo/storage/MergeScanner.java
tajo-storage/src/main/java/org/apache/tajo/storage/StorageManager.java
commit 40aa361cd480c8e29798d11e4e894fc491be661d
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-30T11:08:19Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
commit 8f09273e73cc47a31ad9d585cd3f7e6ad75e840f
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-10-30T13:39:20Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
All test cases pass.
commit 76fb0a06451ecf9e254d3b5d85dafa9a9d248da6
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-10-31T15:40:19Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Add data type verification
commit e8d50a05279517db8ee8e49eec5d5eb369d3a45b
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-01T06:54:56Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Supporting binary split key
commit 37942472653febd82f1a7f55c0cfc79b53d780f4
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-01T08:03:55Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Fix HBaseAppender unsorted bug.
commit b636faf5023ed6523077f46dd4583f9414209e39
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-02T15:46:55Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Support multiple rowkey field.
commit 79cea448833281ffb081d8f21aefa645b082db2f
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-02T16:17:38Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
TupleComparator error
commit 529d48c112099cb8d85311f32a74986a7e2019b8
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-02T16:20:28Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
TupleComparator error
commit 6ec23170f16d3a740714bc909dc8949ad00217e7
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-03T06:20:17Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Implements HBasePutAppender
commit 54974da8c1d0e0837035c9d92b87c4a30f13aa48
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-03T11:25:41Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Implements ColumnKey, Value mapping
commit bfe44fd7953cdeee9c51912aa9f20331cb0c002f
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-03T11:54:53Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Fix queryunit.jsp error
commit ce9de5231a09ad7013f7165258395c68adee8bc4
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-03T11:58:41Z
remove ToCharInt function
commit 73126be997dce5ef77043de4a0aad99eb72c1031
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-03T12:53:52Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Fix index predication bug
commit f28586cfa88eaffab298b0eba38f7c3288dab098
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-11-03T13:44:38Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Fix composite rowkey scanner
commit 97c32e41eb178af1138b7e6f822c3948d3063882
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-04T07:49:03Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Implements Insert into location using hbase
commit 402022f186192f0b1df504ec83b623f7a4f231b8
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-04T08:14:57Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Fix hbase region splitting
commit e156b1c642971e95f364c0668bfced96b567c600
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-04T13:45:11Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Optimize HBase Scanner
commit 12b30c15fb038b757fbf53c393d79336b7232514
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-05T09:07:00Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Add comments
commit 5a3ae8bfe650a07cf5f4f85ef5f3cae03f737a53
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-05T11:05:52Z
Merge branch 'hbase_storage' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1131
Conflicts:
tajo-core/src/main/java/org/apache/tajo/engine/query/QueryContext.java
tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
commit 44e4d632df99c340ad520a1c39ba3efff94ebde7
Author: HyoungJun Kim <ba...@babokim-macbook-pro.local>
Date: 2014-11-05T11:27:21Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Change TupleComparator to BaseTupleComparator.
commit 03ef3158930624acc44ce482f10abcbdcc01e9b4
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-11-10T09:58:05Z
TAJO-1131: Supports Inserting or Creating table into the HBase mapped table.
Move hbase.version property to tajo-project/pom.xml
commit 445019d32c5d3f10522fc11fe6a5ee939f389954
Author: HyoungJun Kim <ba...@babokim-mbp.server.gruter.com>
Date: 2014-11-11T10:19:28Z
TAJO-1122: Refactor the tajo-storage project structure.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848331
--- Diff: tajo-core/src/main/java/org/apache/tajo/worker/dataserver/HttpDataServerHandler.java ---
@@ -189,7 +189,7 @@ public static String sanitizeUri(String uri) {
private void sendError(ChannelHandlerContext ctx, HttpResponseStatus status) {
HttpResponse response = new DefaultHttpResponse(HTTP_1_1, status);
- response.setHeader(CONTENT_TYPE, "text/plain; charset=UTF-8");
+ response.setHeader(CONTENT_TYPE, "org/apache/tajo/storage/text/plain; charset=UTF-8");
--- End diff --
You may not intend to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848280
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/Substr.java ---
@@ -48,7 +48,7 @@
public class Substr extends GeneralFunction {
public Substr() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT),
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT),
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-63265746
Sorry I fixed adding tajo-hcatalog version to tajo-core/pom.xml and changing tajo-storage to tajo-storage-common in tajo-hcatalog/pom.xml. But I don't know exactly why tajo-core/pom.xml need to add a hcatalog version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848324
--- Diff: tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java ---
@@ -212,7 +212,7 @@ private void errorResponse(HttpServletResponse response, String message) throws
}
private void writeHttpResponse(HttpServletResponse response, Map<String, Object> outputMessage) throws IOException {
- response.setContentType("text/html");
+ response.setContentType("org/apache/tajo/storage/text/html");
--- End diff --
You may not intend to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848241
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat.java ---
@@ -47,7 +47,7 @@
public class Concat extends GeneralFunction {
public Concat() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT),
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT),
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848258
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/Digest.java ---
@@ -48,7 +48,7 @@
public class Digest extends GeneralFunction {
public Digest() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT)
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT)
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848470
--- Diff: tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java ---
@@ -22,28 +22,35 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.fs.*;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
import org.apache.tajo.*;
-import org.apache.tajo.catalog.*;
+import org.apache.tajo.catalog.Schema;
+import org.apache.tajo.catalog.SortSpec;
+import org.apache.tajo.catalog.TableDesc;
+import org.apache.tajo.catalog.TableMeta;
import org.apache.tajo.catalog.proto.CatalogProtos;
import org.apache.tajo.catalog.proto.CatalogProtos.FragmentProto;
import org.apache.tajo.catalog.proto.CatalogProtos.StoreType;
import org.apache.tajo.conf.TajoConf;
import org.apache.tajo.conf.TajoConf.ConfVars;
import org.apache.tajo.plan.LogicalPlan;
-import org.apache.tajo.plan.logical.*;
+import org.apache.tajo.plan.logical.LogicalNode;
+import org.apache.tajo.plan.logical.NodeType;
+import org.apache.tajo.plan.logical.ScanNode;
import org.apache.tajo.plan.rewrite.RewriteRule;
-import org.apache.tajo.storage.fragment.FileFragment;
import org.apache.tajo.storage.fragment.Fragment;
import org.apache.tajo.storage.fragment.FragmentConvertor;
-import org.apache.tajo.storage.hbase.HBaseStorageManager;
import org.apache.tajo.util.TUtil;
import java.io.IOException;
import java.lang.reflect.Constructor;
import java.net.URI;
import java.text.NumberFormat;
-import java.util.*;
+import java.util.HashMap;
--- End diff --
It is not unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848250
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java ---
@@ -49,9 +49,9 @@
public Concat_ws() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT),
- new Column("text", TajoDataTypes.Type.TEXT),
- new Column("text", TajoDataTypes.Type.TEXT),
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT),
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by babokim <gi...@git.apache.org>.
Github user babokim closed the pull request at:
https://github.com/apache/tajo/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848268
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/RTrim.java ---
@@ -52,7 +52,7 @@
public RTrim() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT),
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT),
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848260
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/Lower.java ---
@@ -44,7 +44,7 @@
public class Lower extends GeneralFunction {
public Lower() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT)
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT)
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-63257511
TravisCI causes the following compilation errors. Could you check it?
{noformat}
[ERROR] The build could not read 2 projects -> [Help 1]
[ERROR]
[ERROR] The project org.apache.tajo:tajo-core:0.9.1-SNAPSHOT (/home/travis/build/apache/tajo/tajo-core/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.apache.tajo:tajo-hcatalog:jar is missing. @ org.apache.tajo:tajo-core:[unknown-version], /home/travis/build/apache/tajo/tajo-core/pom.xml, line 491, column 21
[ERROR]
[ERROR] The project org.apache.tajo:tajo-hcatalog:0.9.1-SNAPSHOT (/home/travis/build/apache/tajo/tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml) has 1 error
[ERROR] 'dependencies.dependency.version' for org.apache.tajo:tajo-storage:jar is missing. @ org.apache.tajo:tajo-hcatalog:[unknown-version], /home/travis/build/apache/tajo/tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml, line 114, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
{noformat}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-64720235
+1
the patch looks good to me. Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848803
--- Diff: tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java ---
@@ -513,7 +513,7 @@ private void sendError(ChannelHandlerContext ctx,
private void sendError(ChannelHandlerContext ctx, String message,
HttpResponseStatus status) {
HttpResponse response = new DefaultHttpResponse(HTTP_1_1, status);
- response.setHeader(CONTENT_TYPE, "text/plain; charset=UTF-8");
+ response.setHeader(CONTENT_TYPE, "org/apache/tajo/storage/text/plain; charset=UTF-8");
--- End diff --
You may not intend to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848401
--- Diff: tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java ---
@@ -546,7 +545,7 @@ public final void testStorePlanWithRCFile() throws IOException, PlanningExceptio
exec.next();
exec.close();
- Scanner scanner = StorageManager.getFileStorageManager(conf).getFileScanner(outputMeta, rootNode.getOutSchema(),
+ Scanner scanner = ((FileStorageManager)StorageManager.getFileStorageManager(conf)).getFileScanner(outputMeta, rootNode.getOutSchema(),
--- End diff --
The line exceeds 120 column width.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848806
--- Diff: tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java ---
@@ -679,7 +679,7 @@ private void sendError(ChannelHandlerContext ctx,
private void sendError(ChannelHandlerContext ctx, String message,
HttpResponseStatus status) {
HttpResponse response = new DefaultHttpResponse(HTTP_1_1, status);
- response.setHeader(CONTENT_TYPE, "text/plain; charset=UTF-8");
+ response.setHeader(CONTENT_TYPE, "org/apache/tajo/storage/text/plain; charset=UTF-8");
--- End diff --
You may not intend to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848787
--- Diff: tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/HttpDataServerHandler.java ---
@@ -222,7 +222,7 @@ public static String sanitizeUri(String uri) {
private void sendError(ChannelHandlerContext ctx, HttpResponseStatus status) {
HttpResponse response = new DefaultHttpResponse(HTTP_1_1, status);
- response.setHeader(CONTENT_TYPE, "text/plain; charset=UTF-8");
+ response.setHeader(CONTENT_TYPE, "org/apache/tajo/storage/text/plain; charset=UTF-8");
--- End diff --
You may not intend to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/247#discussion_r20848273
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/string/StrPosb.java ---
@@ -47,7 +47,7 @@
public class StrPosb extends GeneralFunction {
public StrPosb() {
super(new Column[] {
- new Column("text", TajoDataTypes.Type.TEXT),
+ new Column("org/apache/tajo/storage/text", TajoDataTypes.Type.TEXT),
--- End diff --
This seems to be changed while you refactor 'text'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-64315689
I'm sorry for late review. Could you rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-64537993
@hyunsik
Thanks for detail review. I just rebased and fixed all that you commented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1122: Refactor the tajo-storage project st...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/247#issuecomment-64325688
As I also mentioned in the jira (https://issues.apache.org/jira/browse/TAJO-1122), I agree with the package hierarchy. I leave some comments. They are mostly trivial things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---