You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/06 18:43:46 UTC

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22461


Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................

[common] minor cleanup on RowBlock/RowBlockRow

This patch addresses a few const-correctness, CHECK/DCHECK and
code style issues in RowBlock/RowBlockRow/SelectionVector classes.

Since I have patches with updates in the related code, I'm publishing
this small clean-up in a separate patch.

This patch doesn't contain any functional modifications.

Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Reviewed-on: http://gerrit.cloudera.org:8080/22450
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 3316848c259804c7e90f3a3b7a21b62db1c51249)
---
M src/kudu/common/columnblock.h
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
3 files changed, 86 insertions(+), 79 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/22461/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 19:47:38 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1044/


-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Feb 2025 18:43:53 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 02:10:16 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................

[common] minor cleanup on RowBlock/RowBlockRow

This patch addresses a few const-correctness, CHECK/DCHECK and
code style issues in RowBlock/RowBlockRow/SelectionVector classes.

Since I have patches with updates in the related code, I'm publishing
this small clean-up in a separate patch.

This patch doesn't contain any functional modifications.

Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Reviewed-on: http://gerrit.cloudera.org:8080/22450
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 3316848c259804c7e90f3a3b7a21b62db1c51249)
Reviewed-on: http://gerrit.cloudera.org:8080/22461
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/common/columnblock.h
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
3 files changed, 86 insertions(+), 79 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Yifan Zhang: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1044/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 21:07:07 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22461 )

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Patch Set 1: Verified+1

unrelated test failures:
  * RELEASE: KUDU-3591
  * TSAN: KUDU-3605


-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 19:40:53 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [common] minor cleanup on RowBlock/RowBlockRow

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [common] minor cleanup on RowBlock/RowBlockRow
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If9eda1ed495875bd77babbf3523bb206dd30e8d5
Gerrit-Change-Number: 22461
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>