You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:28:23 UTC
[GitHub] [arrow] lidavidm commented on a diff in pull request #12820: ARROW-15917: [Java][Docs] Document how to use Flight artifacts
lidavidm commented on code in PR #12820:
URL: https://github.com/apache/arrow/pull/12820#discussion_r845073478
##########
docs/source/java/install.rst:
##########
@@ -28,15 +28,15 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with Java 8 / 9 / 10 / 11.
+Java modules are currently compatible with JDK 8, 9, 10, or 11, but only JDK 11 is tested in CI.
Installing from Maven
---------------------
By default, Maven will download from the central repository: https://repo.maven.apache.org/maven2/org/apache/arrow/
Configure your pom.xml with the Java modules needed, for example:
-``arrow-memory-netty``, ``arrow-format``, and ``arrow-vector``.
+arrow-vector, arrow-memory-netty and flight-core.
Review Comment:
That said: I would rather we show a separate POM with the changes needed for Flight, including os-maven-plugin.
##########
docs/source/java/install.rst:
##########
@@ -82,85 +94,121 @@ Installing Nightly Packages
These packages are not official releases. Use them at your own risk.
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
-The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
+The artifacts are uploaded to GitHub. For example, for 2022/03/19, they can be found at `Github Nightly`_.
Review Comment:
I don't think we need to change the nightly instructions for Flight. We just need to show using os-maven-plugin above.
##########
docs/source/java/install.rst:
##########
@@ -28,15 +28,15 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with Java 8 / 9 / 10 / 11.
+Java modules are currently compatible with JDK 8, 9, 10, or 11, but only JDK 11 is tested in CI.
Installing from Maven
---------------------
By default, Maven will download from the central repository: https://repo.maven.apache.org/maven2/org/apache/arrow/
Configure your pom.xml with the Java modules needed, for example:
-``arrow-memory-netty``, ``arrow-format``, and ``arrow-vector``.
+arrow-vector, arrow-memory-netty and flight-core.
Review Comment:
```suggestion
arrow-vector, arrow-memory-netty, and flight-core.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org