[jira] [Commented] (SOLR-11669) Policy Session lifecycle needs cleanup

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279625#comment-16279625 ] 

ASF subversion and git services commented on SOLR-11669:
--------------------------------------------------------

Commit 071d9270d5e02a40bc36833b15f1e738ca2c3e51 in lucene-solr's branch refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=071d927 ]

SOLR-11669: Policy Session lifecycle cleanup


> Policy Session lifecycle needs cleanup
> --------------------------------------
>
>                 Key: SOLR-11669
>                 URL: https://issues.apache.org/jira/browse/SOLR-11669
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>            Reporter: Andrzej Bialecki 
>            Assignee: Noble Paul
>
> {{Policy.Session}} is used in several places in the autoscaling framework. However, its life-cycle is unclear and inconsistent - in some places ({{ComputePlanAction}}) sessions are created directly via {{Policy.createSession}}, in other places a thread-local caching in {{PolicyHelper}} is used, in still other places the {{ObjectCache}} is used.
> {{Session}} creates a copy of live nodes on instantiation, which may become stale, but {{PolicyHelper}} caching never checks whether this instance is still valid while it's still in cache.
> Also, refcounting leads to awkward and non-intuitive code, such AddReplicaCmd:103.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org