You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/02/15 11:04:27 UTC
[GitHub] flink pull request: [FLINK-1487] Fixes ScheduleIsolatedTasksTest.t...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/398
[FLINK-1487] Fixes ScheduleIsolatedTasksTest.testScheduleQueueing
This PR fixes the ```ScheduleIsolatedTasksTest.testScheduleQueueing```. The problem was that the method ```Scheduler.getNumberOfAvailableSlots``` did only counted the slots of the available instances but not of those which were queued up in the ```newlyAvailableInstances``` queue. Thus, by checking the ```newlyAvailableInstances``` queue before counting, the correct number of slots is returned.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixTestScheduleQueueing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #398
----
commit 13d198a1bd8f1c68d43243d6665958fbb19763c9
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-14T16:38:57Z
[FLINK-1487] [runtime][tests] Fixes SchedulerIsolatedTasksTest.testScheduleQueueing by waiting for the released resources to registered at the Scheduler again.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1487] Fixes ScheduleIsolatedTasksTest.t...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/398#issuecomment-74426751
Perfect! I had overlooked that the counter could be off and this could be the failure cause.
+1
Will merge with the next batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1487] Fixes ScheduleIsolatedTasksTest.t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---