You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "uzqw (via GitHub)" <gi...@apache.org> on 2026/08/23 11:16:10 UTC

Re: [PR] fix(runtime): route OpenCode Go Muse Spark through Responses [maka]

uzqw commented on PR #3549:
URL: https://github.com/apache/maka/pull/3549#issuecomment-5385709469

   @Astro-Han Thank you for taking the time to trace this through the installed AI SDK dependencies and build a wire-level reproduction. Your review was correct, and I’m sorry that my previous approach addressed the symptom without identifying the actual routing problem. I incorrectly treated the SDK-synthesized `finish` event as evidence that the provider had sent `[DONE]`.
   
   After investigating again, I found that the real issue is the API route: Maka was sending `opencode-go/muse-spark-1.2-contributor` through Chat Completions, while this model is served correctly through the Responses API. I also found that oh-my-pi had already merged the same model-specific routing fix in [can1357/oh-my-pi#8980](https://github.com/can1357/oh-my-pi/pull/8980).
   
   I’ve reworked the PR accordingly: the lenient-EOF logic has been removed, the strict truncation and tool-safety checks remain unchanged, and this provider/model pair is now routed to `/responses`. I added tests covering both the scoped protocol selection and the final request endpoint, and verified a real tool-call turn against the live gateway.
   
   Thank you again for catching this and for the detailed explanation—it led me to the correct layer for the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org