[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8235: board: Pass the assertion expression to board_crashdump too

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #8235:
URL: https://github.com/apache/nuttx/pull/8235#discussion_r1086823510


##########
boards/arm/cxd56xx/common/src/cxd56_crashdump.c:
##########
@@ -98,15 +98,14 @@ static void copy_reverse(stack_word_t *dest, stack_word_t *src, int size)
  * Name: board_crashdump
  ****************************************************************************/
 
-void board_crashdump(uintptr_t currentsp, void *tcb,
-                     const char *filename, int lineno)
+void board_crashdump(uintptr_t sp, struct tcb_s *tcb,
+                     const char *filename, int lineno,
+                     const char *msg)

Review Comment:
   Do we need to add something like `UNUSED(msg);`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org