You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2020/07/13 11:05:54 UTC

[maven-dependency-analyzer] branch master updated: remove reference to deprecated public mutable field (#15)

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e9e66f  remove reference to deprecated public mutable field (#15)
2e9e66f is described below

commit 2e9e66ffb71bb0c7164738b7b6bd9471d5eec297
Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
AuthorDate: Mon Jul 13 07:05:46 2020 -0400

    remove reference to deprecated public mutable field (#15)
    
    * remove reference to deprecated public mutable field
---
 pom.xml                                                             | 6 ++++++
 .../shared/dependency/analyzer/asm/DependencyClassFileVisitor.java  | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3b36466..9d41ad3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -106,6 +106,12 @@
       <version>${mavenVersion}</version>
     </dependency>
     <dependency>
+      <groupId>commons-io</groupId>
+      <artifactId>commons-io</artifactId>
+      <version>2.6</version>
+    </dependency>
+    
+    <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-artifact</artifactId>
       <version>${mavenVersion}</version>
diff --git a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
index 1c594ae..e0b41b0 100644
--- a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
+++ b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
@@ -19,6 +19,7 @@ package org.apache.maven.shared.dependency.analyzer.asm;
  * under the License.
  */
 
+import org.apache.commons.io.IOUtils;
 import org.apache.maven.shared.dependency.analyzer.ClassFileVisitor;
 import org.objectweb.asm.AnnotationVisitor;
 import org.objectweb.asm.ClassReader;
@@ -62,9 +63,10 @@ public class DependencyClassFileVisitor
     {
         try
         {
-            ClassReader reader = new ClassReader( in );
+            byte[] byteCode = IOUtils.toByteArray( in );
+            ClassReader reader = new ClassReader( byteCode );
 
-            final Set<String> constantPoolClassRefs = ConstantPoolParser.getConstantPoolClassReferences( reader.b );
+            final Set<String> constantPoolClassRefs = ConstantPoolParser.getConstantPoolClassReferences( byteCode );
             for ( String string : constantPoolClassRefs )
             {
                 resultCollector.addName( string );