You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 04:28:16 UTC
[GitHub] [airflow] o-nikolas opened a new pull request, #28717: Update new committer onboarding steps
o-nikolas opened a new pull request, #28717:
URL: https://github.com/apache/airflow/pull/28717
Include a new step to update ci.yml and project.rst with your alias/name
Screenshot of the rendered changes for review:
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061149486
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
Github → GitHub
It’s probably better to use _GitHub ID_ instead of _alias_? That’s how it’s called elsewhere in the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061740765
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
Sure, will do :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
o-nikolas commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061739836
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
Sure, I was working with the assumption that the individual is working through the steps in order, but it's better to be safe than sorry :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28717:
URL: https://github.com/apache/airflow/pull/28717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061146553
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
```suggestion
7. After confirmation step 6 is done, open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
```
If not mistaken its important that 7 will happen after otherwise your PRs will not get CI resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061149486
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
Github → GitHub
It’s probably better to use username instead of alias?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28717: Update new committer onboarding steps
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28717:
URL: https://github.com/apache/airflow/pull/28717#discussion_r1061149486
##########
COMMITTERS.rst:
##########
@@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
4. Wait at least 30 minutes for an email inviting you to Apache GitHub Organization and accept invitation.
5. After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.
6. Ask in ``#internal-airflow-ci-cd`` channel to be `configured in self-hosted runners <https://github.com/apache/airflow-ci-infra/blob/main/scripts/list_committers>`_ by the CI maintainers
+7. Open a PR to include your Github alias in `ci.yml <https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L72>`__ as well as your name and alias in `project.rst <https://github.com/apache/airflow/blob/main/docs/apache-airflow/project.rst>`__.
Review Comment:
Github → GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org