You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/03 22:42:14 UTC

[GitHub] [helix] alirezazamani commented on a change in pull request #834: Complete the Routing Table Provider for CustomizedView

alirezazamani commented on a change in pull request #834: Complete the Routing Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r387339094
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingDataCache.java
 ##########
 @@ -41,13 +44,24 @@
   private static Logger LOG = LoggerFactory.getLogger(RoutingDataCache.class.getName());
 
   private final PropertyType _sourceDataType;
+  // Aggregation type is used for CustomizedView only.
+  private final String _aggregationType;
+
   private CurrentStateCache _currentStateCache;
+  private CustomizedViewCache _customizedViewCache;
   private TargetExternalViewCache _targetExternalViewCache;
 
+
   public RoutingDataCache(String clusterName, PropertyType sourceDataType) {
+    this (clusterName, sourceDataType, null);
+  }
+
+  public RoutingDataCache(String clusterName, PropertyType sourceDataType, String aggregationType) {
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org