You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/28 16:08:43 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests
lordgamez opened a new pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982#discussion_r566304366
##########
File path: docker/Dockerfile
##########
@@ -127,7 +127,7 @@ RUN cd ${MINIFI_BASE_DIR} \
-DDISABLE_CURL=${DISABLE_CURL} -DDISABLE_JEMALLOC=${DISABLE_JEMALLOC} -DDISABLE_CIVET=${DISABLE_CIVET} \
-DDISABLE_EXPRESSION_LANGUAGE=${DISABLE_EXPRESSION_LANGUAGE} -DDISABLE_ROCKSDB=${DISABLE_ROCKSDB} \
-DDISABLE_LIBARCHIVE=${DISABLE_LIBARCHIVE} -DDISABLE_LZMA=${DISABLE_LZMA} -DDISABLE_BZIP2=${DISABLE_BZIP2} \
- -DDISABLE_SCRIPTING=${DISABLE_SCRIPTING} -DDISABLE_CONTROLLER=${DISABLE_CONTROLLER} .. \
Review comment:
The problem with `RelWithDebInfo` was that it resulted in way too big docker images, due to the large minifi and minificontroller libraries when debuginfo was included. With Release the final image is 232MB with AWS and Kafka included, but with debuginfo the image size becomes more thatn 600MBs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982#discussion_r566242574
##########
File path: docker/Dockerfile
##########
@@ -127,7 +127,7 @@ RUN cd ${MINIFI_BASE_DIR} \
-DDISABLE_CURL=${DISABLE_CURL} -DDISABLE_JEMALLOC=${DISABLE_JEMALLOC} -DDISABLE_CIVET=${DISABLE_CIVET} \
-DDISABLE_EXPRESSION_LANGUAGE=${DISABLE_EXPRESSION_LANGUAGE} -DDISABLE_ROCKSDB=${DISABLE_ROCKSDB} \
-DDISABLE_LIBARCHIVE=${DISABLE_LIBARCHIVE} -DDISABLE_LZMA=${DISABLE_LZMA} -DDISABLE_BZIP2=${DISABLE_BZIP2} \
- -DDISABLE_SCRIPTING=${DISABLE_SCRIPTING} -DDISABLE_CONTROLLER=${DISABLE_CONTROLLER} .. \
Review comment:
I would go for `RelWithDebInfo` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #982: MINIFICPP-1465 Add AWS to docker minimal image and 16.04 all tests
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #982:
URL: https://github.com/apache/nifi-minifi-cpp/pull/982#discussion_r566304366
##########
File path: docker/Dockerfile
##########
@@ -127,7 +127,7 @@ RUN cd ${MINIFI_BASE_DIR} \
-DDISABLE_CURL=${DISABLE_CURL} -DDISABLE_JEMALLOC=${DISABLE_JEMALLOC} -DDISABLE_CIVET=${DISABLE_CIVET} \
-DDISABLE_EXPRESSION_LANGUAGE=${DISABLE_EXPRESSION_LANGUAGE} -DDISABLE_ROCKSDB=${DISABLE_ROCKSDB} \
-DDISABLE_LIBARCHIVE=${DISABLE_LIBARCHIVE} -DDISABLE_LZMA=${DISABLE_LZMA} -DDISABLE_BZIP2=${DISABLE_BZIP2} \
- -DDISABLE_SCRIPTING=${DISABLE_SCRIPTING} -DDISABLE_CONTROLLER=${DISABLE_CONTROLLER} .. \
Review comment:
The problem with `RelWithDebInfo` was that it resulted in way too big docker images, due to the large minifi and minificontroller libraries when debuginfo was included. With Release the final image is 232MB with AWS and Kafka included, but with debuginfo the image size becomes more than 600MBs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org