[GitHub] [doris] yiguolei commented on a diff in pull request #15681: [fix](schema change) bugfix for light schema change while with rollup

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #15681:
URL: https://github.com/apache/doris/pull/15681#discussion_r1064232485


##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1106,18 +1106,20 @@ private void checkAndAddColumn(List<Column> modIndexSchema, Column newColumn, Co
             hasPos = true;
         }
 
-        newColumn.setUniqueId(newColumnUniqueId);
+        // newColumn may add to baseIndex or rollups, so we need copy before change UniqueId

Review Comment:
   Does doris support add a column to rollup and the column is not in base table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org