You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/11/17 09:09:11 UTC

[PR] [minor](stats) Fix potential npe when loading stats [doris]

Kikyou1997 opened a new pull request, #27200:
URL: https://github.com/apache/doris/pull/27200

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #27200:
URL: https://github.com/apache/doris/pull/27200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822149272

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 52b3198691a4e7682cc56e79e5ca20a9ffdebc4f, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4893	4655	4657	4655
   q2	361	168	157	157
   q3	2038	1908	1879	1879
   q4	1391	1274	1238	1238
   q5	3948	3955	4006	3955
   q6	251	134	129	129
   q7	1443	893	896	893
   q8	2739	2768	2754	2754
   q9	9744	9628	9552	9552
   q10	3479	3543	3532	3532
   q11	378	247	250	247
   q12	441	290	290	290
   q13	4559	3855	3799	3799
   q14	326	292	283	283
   q15	583	534	529	529
   q16	660	593	582	582
   q17	1138	984	948	948
   q18	7842	7480	7237	7237
   q19	1652	1677	1672	1672
   q20	532	298	319	298
   q21	4399	3951	3954	3951
   q22	488	377	365	365
   Total cold run time: 53285 ms
   Total hot run time: 48945 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4571	4584	4580	4580
   q2	328	243	258	243
   q3	3996	3986	4015	3986
   q4	2702	2683	2696	2683
   q5	9712	9761	9776	9761
   q6	239	127	124	124
   q7	3013	2466	2512	2466
   q8	4420	4484	4425	4425
   q9	13202	13129	13093	13093
   q10	4095	4180	4180	4180
   q11	855	672	659	659
   q12	1000	804	810	804
   q13	4294	3594	3529	3529
   q14	383	348	370	348
   q15	583	519	538	519
   q16	732	694	684	684
   q17	3898	3851	3849	3849
   q18	9581	9011	8948	8948
   q19	1804	1780	1771	1771
   q20	2383	2076	2053	2053
   q21	8941	8552	8704	8552
   q22	847	770	753	753
   Total cold run time: 81579 ms
   Total hot run time: 78010 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1816004068

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1816000132

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "shuke987 (via GitHub)" <gi...@apache.org>.
shuke987 commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822043690

   run clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822490971

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 385432c388464a11de37360309e4f8343ab5b57b, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4917	4686	4616	4616
   q2	357	151	160	151
   q3	2043	1944	1873	1873
   q4	1380	1260	1232	1232
   q5	3944	3952	4048	3952
   q6	249	127	131	127
   q7	1443	884	887	884
   q8	2727	2762	2758	2758
   q9	9723	9532	9486	9486
   q10	3453	3500	3516	3500
   q11	380	243	252	243
   q12	445	298	291	291
   q13	4578	4006	4088	4006
   q14	314	287	283	283
   q15	601	525	539	525
   q16	655	575	579	575
   q17	1131	943	923	923
   q18	7822	7371	7302	7302
   q19	1644	1665	1664	1664
   q20	528	324	291	291
   q21	4386	3955	3983	3955
   q22	481	379	362	362
   Total cold run time: 53201 ms
   Total hot run time: 48999 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4606	4589	4576	4576
   q2	335	244	246	244
   q3	4025	3990	3973	3973
   q4	2699	2681	2700	2681
   q5	9568	9508	9565	9508
   q6	241	126	123	123
   q7	3009	2461	2440	2440
   q8	4423	4403	4438	4403
   q9	13097	13054	12990	12990
   q10	4082	4185	4186	4185
   q11	750	694	633	633
   q12	964	817	823	817
   q13	4302	3591	3585	3585
   q14	394	351	345	345
   q15	579	529	526	526
   q16	734	676	685	676
   q17	3915	3897	3888	3888
   q18	9391	9053	9029	9029
   q19	1772	1774	1765	1765
   q20	2392	2080	2052	2052
   q21	8946	8385	8562	8385
   q22	885	838	807	807
   Total cold run time: 81109 ms
   Total hot run time: 77631 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822486836

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 43.87 seconds
    stream load tsv:          567 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17099269732 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822425752

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 52b3198691a4e7682cc56e79e5ca20a9ffdebc4f, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4883	4676	4673	4673
   q2	370	171	159	159
   q3	2039	1895	1857	1857
   q4	1393	1280	1232	1232
   q5	3966	3922	3959	3922
   q6	240	125	130	125
   q7	1399	903	885	885
   q8	2744	2767	2749	2749
   q9	9930	9556	9688	9556
   q10	3447	3523	3540	3523
   q11	392	244	249	244
   q12	434	290	296	290
   q13	4562	3795	3797	3795
   q14	314	291	275	275
   q15	594	538	522	522
   q16	668	592	571	571
   q17	1119	954	928	928
   q18	7870	7375	7429	7375
   q19	1670	1678	1667	1667
   q20	535	305	294	294
   q21	4341	3924	3995	3924
   q22	485	368	367	367
   Total cold run time: 53395 ms
   Total hot run time: 48933 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4579	4580	4544	4544
   q2	345	222	248	222
   q3	4032	3988	3992	3988
   q4	2704	2704	2685	2685
   q5	9610	9558	9506	9506
   q6	241	120	124	120
   q7	3009	2469	2467	2467
   q8	4442	4432	4434	4432
   q9	13174	13114	13112	13112
   q10	4083	4201	4232	4201
   q11	787	630	661	630
   q12	966	797	808	797
   q13	4321	3565	3580	3565
   q14	379	343	341	341
   q15	580	516	519	516
   q16	746	688	673	673
   q17	3827	3855	3803	3803
   q18	9607	8836	8883	8836
   q19	1838	1777	1747	1747
   q20	2380	2074	2075	2074
   q21	8740	8650	8495	8495
   q22	904	826	785	785
   Total cold run time: 81294 ms
   Total hot run time: 77539 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822272023

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1823921821

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822155465

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.61 seconds
    stream load tsv:          575 seconds loaded 74807831229 Bytes, about 124 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
    storage size: 17099578795 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1822432950

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [minor](stats) Fix potential npe when loading stats [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27200:
URL: https://github.com/apache/doris/pull/27200#issuecomment-1818752505

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org