You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2025/04/25 20:27:36 UTC
[native-toolchain-CR] IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22820
Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
......................................................................
IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
tcmalloc currently limits the total thread cache size to 1GB.
On large systems with many threads, this may be insufficient,
causing extra memory transfers between thread caches. This
patches gperftools to remove this 1GB constraint.
This also stops building gperftools 2.8.0 and removes its code.
Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
---
M buildall.sh
A source/gperftools/gperftools-2.10-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.15-patches/0001-Remove-1GB-thread-cache-limit.patch
D source/gperftools/gperftools-2.8.1-patches/0001-Port-gperftools-to-adapt-aarch64.patch
4 files changed, 24 insertions(+), 242 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/20/22820/1
--
To view, visit http://gerrit.cloudera.org:8080/22820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Gerrit-Change-Number: 22820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22820 )
Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Gerrit-Change-Number: 22820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 26 Apr 2025 07:32:02 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22820 )
Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
......................................................................
IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
tcmalloc currently limits the total thread cache size to 1GB.
On large systems with many threads, this may be insufficient,
causing extra memory transfers between thread caches. This
patches gperftools to remove this 1GB constraint.
This also stops building gperftools 2.8.0 and removes its code.
Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Reviewed-on: http://gerrit.cloudera.org:8080/22820
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
A source/gperftools/gperftools-2.10-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.15-patches/0001-Remove-1GB-thread-cache-limit.patch
D source/gperftools/gperftools-2.8.1-patches/0001-Port-gperftools-to-adapt-aarch64.patch
4 files changed, 24 insertions(+), 242 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Quanlong Huang: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Gerrit-Change-Number: 22820
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22820 )
Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
......................................................................
Patch Set 1: Code-Review+2
Carry Michael's +1.
--
To view, visit http://gerrit.cloudera.org:8080/22820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Gerrit-Change-Number: 22820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 26 Apr 2025 03:06:10 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22820 )
Change subject: IMPALA-13479: Patch gperftools to remove 1GB limit on thread caches
......................................................................
Patch Set 1: Code-Review+1
Abseil - https://github.com/google/tcmalloc/blob/0b8b843c1e3133db121a674089a5acf54abb5fc5/tcmalloc/thread_cache.cc - omitted this limit. So seems fine to me.
--
To view, visit http://gerrit.cloudera.org:8080/22820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I709b9ca04c71b14e2dd157d4daaa86e8113a38d6
Gerrit-Change-Number: 22820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 20:35:19 +0000
Gerrit-HasComments: No