You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/03 02:51:29 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1403: [CELEBORN-484][FOLLOWUP] Return shutting worker is empty also need to retain LifecycleManager's shutting workers
AngersZhuuuu opened a new pull request, #1403:
URL: https://github.com/apache/incubator-celeborn/pull/1403
### What changes were proposed in this pull request?
Return shutting worker is empty also need to retain LifecycleManager's shutting workers
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1403: [CELEBORN-484][FOLLOWUP] Return shutting worker is empty also need to retain LifecycleManager's shutting workers
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1403:
URL: https://github.com/apache/incubator-celeborn/pull/1403#issuecomment-1493598997
ping @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1403: [CELEBORN-484][FOLLOWUP] Return shutting worker is empty also need to retain LifecycleManager's shutting workers
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1403:
URL: https://github.com/apache/incubator-celeborn/pull/1403#issuecomment-1493572973
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1403?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1403](https://codecov.io/gh/apache/incubator-celeborn/pull/1403?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0f49b3) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/b4f8ab19bd2b7c46363dcd9293790bc6f40501b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f8ab1) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 45.01% 44.66% -0.34%
==========================================
Files 164 164
Lines 10393 10393
Branches 1057 1057
==========================================
- Hits 4677 4641 -36
- Misses 5376 5413 +37
+ Partials 340 339 -1
```
[see 6 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1403/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1403: [CELEBORN-484][FOLLOWUP] Return shutting worker is empty also need to retain LifecycleManager's shutting workers
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1403:
URL: https://github.com/apache/incubator-celeborn/pull/1403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org