You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 13:56:28 UTC

[GitHub] [airflow] ashb commented on a change in pull request #20163: Mypy fixes to DagRun, TaskInstance, and db utils

ashb commented on a change in pull request #20163:
URL: https://github.com/apache/airflow/pull/20163#discussion_r765811262



##########
File path: airflow/models/dagrun.py
##########
@@ -398,7 +398,9 @@ def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str:
 
     @provide_session
     def get_task_instances(
-        self, state: Optional[Iterable[TaskInstanceState]] = None, session=None
+        self,
+        state: Optional[Iterable[Optional[TaskInstanceState]]] = None,

Review comment:
       Isn't `None` a valid TaskInstanceState? https://github.com/apache/airflow/blob/820e836c4a2e45239279d4d71e1db9434022fec5/airflow/utils/state.py#L35




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org