You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/21 16:40:03 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #5740: Add heart beat response #control-panel-cluster

menghaoranss opened a new pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740


   For #5666 .
   
   Changes proposed in this pull request:
   - Add heart beat response
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740#discussion_r429121918



##########
File path: shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/response/HeartBeatResponse.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.response;
+
+import lombok.Getter;
+
+import java.util.Map;
+
+/**
+ * Heart beat response.
+ */
+@Getter
+public final class HeartBeatResponse {
+    
+    private Map<String, HeartBeatResult> heartBeatResultMap;

Review comment:
       HeartBeatResult shoud be Collection, i will fix it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740#issuecomment-632239610


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=h1) Report
   > Merging [#5740](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/587187791eac346878a457e436025518ed7f0f3e&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5740/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5740      +/-   ##
   ============================================
   - Coverage     53.20%   53.19%   -0.01%     
     Complexity      431      431              
   ============================================
     Files          1168     1169       +1     
     Lines         20572    20576       +4     
     Branches       3708     3708              
   ============================================
   + Hits          10945    10946       +1     
   - Misses         8958     8961       +3     
     Partials        669      669              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...re/cluster/heartbeat/ClusterHeartBeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRCZWF0SW5zdGFuY2UuamF2YQ==) | `44.44% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../cluster/heartbeat/response/HeartBeatResponse.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9yZXNwb25zZS9IZWFydEJlYXRSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/heartbeat/event/HeartBeatDetectNoticeEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9ldmVudC9IZWFydEJlYXREZXRlY3ROb3RpY2VFdmVudC5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=footer). Last update [5871877...142104f](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking merged pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740#discussion_r429026118



##########
File path: shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/response/HeartBeatResponse.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.response;
+
+import lombok.Getter;
+
+import java.util.Map;
+
+/**
+ * Heart beat response.
+ */
+@Getter
+public final class HeartBeatResponse {
+    
+    private Map<String, HeartBeatResult> heartBeatResultMap;

Review comment:
       The key of map is schema name, value is result of each datasource.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740#discussion_r428801310



##########
File path: shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/response/HeartBeatResponse.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.cluster.heartbeat.response;
+
+import lombok.Getter;
+
+import java.util.Map;
+
+/**
+ * Heart beat response.
+ */
+@Getter
+public final class HeartBeatResponse {
+    
+    private Map<String, HeartBeatResult> heartBeatResultMap;

Review comment:
       why a map here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5740: Add heart beat response #control-panel-cluster

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5740:
URL: https://github.com/apache/shardingsphere/pull/5740#issuecomment-632239610


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=h1) Report
   > Merging [#5740](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/587187791eac346878a457e436025518ed7f0f3e&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `20.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5740/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5740      +/-   ##
   ============================================
   - Coverage     53.20%   53.14%   -0.07%     
   - Complexity      431      432       +1     
   ============================================
     Files          1168     1170       +2     
     Lines         20572    20592      +20     
     Branches       3708     3709       +1     
   ============================================
   - Hits          10945    10943       -2     
   - Misses         8958     8980      +22     
     Partials        669      669              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...re/cluster/heartbeat/ClusterHeartBeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRCZWF0SW5zdGFuY2UuamF2YQ==) | `44.44% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../cluster/heartbeat/response/HeartBeatResponse.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9yZXNwb25zZS9IZWFydEJlYXRSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/heartbeat/event/HeartBeatDetectNoticeEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9ldmVudC9IZWFydEJlYXREZXRlY3ROb3RpY2VFdmVudC5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...here/proxy/context/ShardingSphereProxyContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb250ZXh0L1NoYXJkaW5nU3BoZXJlUHJveHlDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/proxy/backend/schema/ShardingSphereSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWFzLmphdmE=) | `26.92% <0.00%> (-3.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../db/protocol/mysql/payload/MySQLPacketPayload.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BheWxvYWQvTXlTUUxQYWNrZXRQYXlsb2FkLmphdmE=) | `93.39% <0.00%> (-3.67%)` | `0.00% <0.00%> (ø%)` | |
   | [.../shardingsphere/kernal/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUta2VybmFsL3NoYXJkaW5nc3BoZXJlLWtlcm5hbC1jb250ZXh0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9rZXJuYWwvY29udGV4dC9TY2hlbWFDb250ZXh0cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/proxy/backend/schema/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...proxy/backend/executor/BackendExecutorContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGVjdXRvci9CYWNrZW5kRXhlY3V0b3JDb250ZXh0LmphdmE=) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...xy/backend/text/admin/BroadcastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL0Jyb2FkY2FzdEJhY2tlbmRIYW5kbGVyLmphdmE=) | `85.71% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/5740/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=footer). Last update [5871877...23ac0d6](https://codecov.io/gh/apache/shardingsphere/pull/5740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org