[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5834: [ISSUE #5832] Fix consumerCount increasing rapidly without sending message

[GitBox <gi...@apache.org>]

Oliverwqcwrw commented on code in PR #5834:
URL: https://github.com/apache/rocketmq/pull/5834#discussion_r1063162445


##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -849,7 +849,11 @@ public GetMessageResult getMessage(final String group, final String topic, final
                                 continue;
                             }
 
-                            this.storeStatsService.getGetMessageTransferredMsgCount().add(cqUnit.getBatchNum());
+                            if (topicConfig.isPresent()) {
+                                if (!topicConfig.get().getTopicName().contains(TopicValidator.RMQ_SYS_REVIVE_LOG)) {

Review Comment:
   
   IMO, It will broke the current structure of StoreStatsService if moving the getMessageTranferredMsgCount to BrokerStatsManager,
   
   because not only is getMessageTransferredMsgCount in there but also other metrics is there,
   
   whether moving the other metrics if moving getMessageTransferredMsgCount to BrokerStatsManager?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org