[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #7207: [WIP][Bug-7206] [MasterServer] fix process isntance always running when task timeout

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #7207:
URL: https://github.com/apache/dolphinscheduler/pull/7207#discussion_r762760425



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -92,16 +92,16 @@ private void checkTask() {
         for (TaskInstance taskInstance : this.taskInstanceCheckList.values()) {
             if (TimeoutFlag.OPEN == taskInstance.getTaskDefine().getTimeoutFlag()) {
                 long timeRemain = DateUtils.getRemainTime(taskInstance.getStartTime(), taskInstance.getTaskDefine().getTimeout() * Constants.SEC_2_MINUTES_TIME_UNIT);
-                if (0 >= timeRemain && processTimeout(taskInstance)) {
-                    taskInstanceCheckList.remove(taskInstance.getId());

Review comment:
       if not remove, it may create timeout event more than 1 time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org