[jira] Commented: (WICKET-3008) clarify purpose of getMarkupSettings().setThrowExceptionOnMissingXmlDeclaration(true)

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921651#action_12921651 ] 

Juergen Donnerstag commented on WICKET-3008:
--------------------------------------------

purpose was "have no encoding issues when opening the markup files in the editor or IDE" but also during render. The xml encoding is read and applied by Wicket while reading the file, irrespective of the encoding requested by the browser. The encodings are translated automatically.

A design time test of course would be nicer to prevent detect errors early.


> clarify purpose of getMarkupSettings().setThrowExceptionOnMissingXmlDeclaration(true)
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-3008
>                 URL: https://issues.apache.org/jira/browse/WICKET-3008
>             Project: Wicket
>          Issue Type: Wish
>            Reporter: Peter Ertl
>            Priority: Minor
>
> After "discovering" getMarkupSettings().setThrowExceptionOnMissingXmlDeclaration(true) I checked it out just to realize that quite a few wicket pages have __no__ <?xml ...?> declaration. 
> For example ExceptionErrorPage has none which ends up in a pretty funny situation:
> I tried to render my MissingXmlPrologPage which caused wicket, due to the setting, to render ExceptionErrorPage to complain about the missing xml prolog. But ExceptionErrorPage had no xml prolog which again made wicket call the exception page to complain about "no xml prolog". This ended in an  cascaded exception firing and finally in a blank page :-)
> Is this setting supposed to be deprecated? In case it's not we should:
> - enforce declaration of the xml prolog in all wicket project related pages by adding a test case to the build procedure (somehow similar to the apache license header check)
> - communicate this to all additional wicket projects clearly
> - add some documentation on the benefits of using this setting (I guess it's mostly about having no encoding issues when opening the markup files in the editor or IDE)
> - or if it's useless, just drop it

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.