You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2023/03/27 13:58:00 UTC
[jira] [Commented] (OAK-9989) introduce oak-shaded-guava project
[ https://issues.apache.org/jira/browse/OAK-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705374#comment-17705374 ]
Julian Reschke commented on OAK-9989:
-------------------------------------
Hm, still not convinced. But let's clarify what would need to be done:
1. Decide on the repo name ("jackrabbit-oak-guava"? "jackrabbit-guava")?
2. Decide on versioning/version numbers (same as for the shaded Gauav version...?)
> introduce oak-shaded-guava project
> ----------------------------------
>
> Key: OAK-9989
> URL: https://issues.apache.org/jira/browse/OAK-9989
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Major
> Fix For: 1.52.0
>
> Attachments: convert-guava.sh
>
>
> Plan:
> 1. add shaded Guava project
> 2. change all internal uses of Guava to use o.a.j.oak.guava.* (or replace by JDK methods)
> 3. remove all Guava uses in public APIs (separate ticket)
> Note: IDEs do not work well with the shade plugin. In Intellij, you'll have to disable the wrapped-guava project. In Eclipse, you even need to remove it. The alternative would be to move the whole subproject outside the Oak reactor pom (opinions?).
> Note 2: the current proposed patch uses Guava 20, as it is mostly (OAK-10151) compatible with Guava 15 and allows us to migrate away from APIs that were removed in version 21. Once done with that, we'd update to newer Guava versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)